Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050186 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-09-07 11:10 | 2022-09-27 07:58 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050186: junit test DataSourceSecuritytest is quite slow because of repeated changeProfile calls | |||||||
| Description | This junit test does a single login and then runs several tests for various roles. Before each individual (parametrized) test it calls changeProfile which essentially calls the UserInfoWidgetActionHandler in the backend. Those repeated calls sum up to half of the total runtime of this test. Skipping the call in case of not having any actual change in role removes most of the overhead. | |||||||
| Steps To Reproduce | Check time spent in changeProfile call compared to per-test call. | |||||||
| Proposed Solution | Save last values (role,org,lang,warehouse) inside the call and skip switching in case all parameters are the same last time | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0140784) hgbot (developer) 2022-09-07 11:13 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/702 [^] |
|
(0141386) hgbot (developer) 2022-09-27 07:58 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/702 [^] |
|
(0141387) hgbot (developer) 2022-09-27 07:58 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: cdbbdcfee81527186748c4d2cbeb33f256520d83 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 27-09-2022 07:57:24 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/cdbbdcfee81527186748c4d2cbeb33f256520d83 [^] Fixes ISSUE-50186. Speedup DataSourceSecurity test. This test issues a bigger number of changeProfile calls (one per parametrized test). Optimize away the backend http call in case the requested params are the same as used last time. --- M src-test/src/org/openbravo/test/datasource/BaseDataSourceTestDal.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-07 11:10 | shuehner | New Issue | |
| 2022-09-07 11:10 | shuehner | Assigned To | => shuehner |
| 2022-09-07 11:10 | shuehner | Modules | => Core |
| 2022-09-07 11:10 | shuehner | Triggers an Emergency Pack | => No |
| 2022-09-07 11:13 | hgbot | Note Added: 0140784 | |
| 2022-09-27 07:58 | hgbot | Resolution | open => fixed |
| 2022-09-27 07:58 | hgbot | Status | new => closed |
| 2022-09-27 07:58 | hgbot | Note Added: 0141386 | |
| 2022-09-27 07:58 | hgbot | Fixed in Version | => PR22Q4 |
| 2022-09-27 07:58 | hgbot | Note Added: 0141387 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |