Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050116 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-08-31 00:10 | 2022-09-05 23:57 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050116: The safeboxes object should be removed from the LocalStorage | |||||||
| Description | Currently, when a POS terminal is configured to use safeboxes, all the safeboxes available for that terminal are loaded during login and stored in the LocalStorage. This can be a problem because the size of the LocalStorage is very limited and the size of the safeboxes info can get very big (many safeboxes available, each having many payment methods). Because we also use the LocalStorage to persist the state, we should only store there whatever is really needed, and the info about the safeboxes available can be stored elsewhere (i.e. on as an IndexedDB model) | |||||||
| Steps To Reproduce | See the attached image to check how the safeboxes object is the biggest one on a real client, it is even bigger than the uncompressed persisted state. | |||||||
| Proposed Solution | Remove the safeboxes object from the LocalStorage, store it as a IndexedDB model | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  LocalStorageObjectSize.png [^] (35,213 bytes) 2022-08-31 00:10
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0140505) hgbot (developer) 2022-08-31 00:24 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/907 [^] |
|
(0140506) hgbot (developer) 2022-08-31 00:27 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1171 [^] |
|
(0140722) hgbot (developer) 2022-09-05 23:27 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 134dc926ed76e706e60b1b78332b4c5038bb9f2e Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 05-09-2022 14:05:19 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/134dc926ed76e706e60b1b78332b4c5038bb9f2e [^] Fixes ISSUE-50116: Adds a SafeboxModelController The new SafeboxModelController can be used to store safebox in an IndexedDB store. It will be used to replace the safebox storage, removing them from the localstorage. The removal from the localstorage for the react POS application will be done in this MR, but the removal from the Enyo POS will be done later on. --- A web/org.openbravo.retail.posterminal/app/model/safebox/SafeboxModel.js A web/org.openbravo.retail.posterminal/app/model/safebox/SafeboxModelController.js M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java --- |
|
(0140723) hgbot (developer) 2022-09-05 23:27 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/907 [^] |
|
(0140724) hgbot (developer) 2022-09-05 23:57 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1171 [^] |
|
(0140725) hgbot (developer) 2022-09-05 23:57 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 7b6d9ff229e1d44d65a98105ee5662de3326531d Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 05-09-2022 23:27:27 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7b6d9ff229e1d44d65a98105ee5662de3326531d [^] Fixes ISSUE-50116: Removes safeboxes from LocalStorage, use SafeboxModelController to persist them in IndexedDB Now in LoadSafeboxes instead of storing the safeboxes in the LocalStorage, we use SafeboxModelController to persist them in IndexedDB. The rest of the changes just update the code to persist and retrieve the list of available safeboxes --- M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/__test__/SelectDrawerStep.test.jsx M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/stories/SelectDrawerStep.stories.jsx M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/__test__/SafeboxHistory.test.jsx M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/safeboxHistory/LoadSafeboxes.js M web-jspack/org.openbravo.pos2/src/ob-init.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-08-31 00:10 | AugustoMauch | New Issue | |
| 2022-08-31 00:10 | AugustoMauch | Assigned To | => Retail |
| 2022-08-31 00:10 | AugustoMauch | File Added: LocalStorageObjectSize.png | |
| 2022-08-31 00:10 | AugustoMauch | OBNetwork customer | => No |
| 2022-08-31 00:10 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-08-31 00:10 | AugustoMauch | Assigned To | Retail => AugustoMauch |
| 2022-08-31 00:11 | AugustoMauch | Status | new => scheduled |
| 2022-08-31 00:11 | AugustoMauch | Status | scheduled => acknowledged |
| 2022-08-31 00:11 | AugustoMauch | Status | acknowledged => scheduled |
| 2022-08-31 00:24 | hgbot | Merge Request Status | => open |
| 2022-08-31 00:24 | hgbot | Note Added: 0140505 | |
| 2022-08-31 00:27 | hgbot | Note Added: 0140506 | |
| 2022-09-05 11:50 | hgbot | Merge Request Status | open => approved |
| 2022-09-05 23:27 | hgbot | Resolution | open => fixed |
| 2022-09-05 23:27 | hgbot | Status | scheduled => closed |
| 2022-09-05 23:27 | hgbot | Fixed in Version | => RR22Q4 |
| 2022-09-05 23:27 | hgbot | Note Added: 0140722 | |
| 2022-09-05 23:27 | hgbot | Note Added: 0140723 | |
| 2022-09-05 23:57 | hgbot | Note Added: 0140724 | |
| 2022-09-05 23:57 | hgbot | Fixed in Version | RR22Q4 => 22Q4 |
| 2022-09-05 23:57 | hgbot | Note Added: 0140725 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |