Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050112
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Web POSminorhave not tried2022-08-30 13:052022-12-14 08:18
ReporterjusancoView Statuspublic 
Assigned Togaboflash 
PrioritynormalResolutionfixedFixed in VersionRR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050112: Pay Open Tickets - Generate single payment

DescriptionThis process currently includes a limitation: even though the application initially tracks real payments done by the user, later on when the orders are completed, instead the payments are split among the different tickets.

This is not correct according to the Openbravo payment model, as instead, a single payment should be created in the backoffice, and then both orders should be associated with it. However, so far it worked in this way due to the fact that the OrderLoader currently cannot create payments associated with multiple tickets. The main objective of this project is to remove this limitation.

The previous way of working will be preserved for compatibility reasons. A new flag should be added in the Organization Retail Tab for this. The new behavior should be marked as default, even for previous customers.
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0143416)
hgbot (developer)
2022-11-10 16:02

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/985 [^]
(0144062)
hgbot (developer)
2022-11-23 20:10

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/246 [^]
(0144221)
hgbot (developer)
2022-11-29 12:17

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/172 [^]
(0144222)
hgbot (developer)
2022-11-29 12:17

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/36 [^]
(0144223)
hgbot (developer)
2022-11-29 12:17

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/48 [^]
(0144224)
hgbot (developer)
2022-11-29 12:18

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/32 [^]
(0144225)
hgbot (developer)
2022-11-29 12:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0bbd963b6058c85e6a4214842a0bac3cf46efbfd
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 29-11-2022 12:27:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0bbd963b6058c85e6a4214842a0bac3cf46efbfd [^]

Fixed ISSUE-50112: Implement Pay Open Tickets in single payment refactor. Merge branch 'fr/50112'

---
M src-db/database/model/modifiedTables/AD_ORG.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/term/Terminal.java
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteMultiTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiTicket.js
---
(0144226)
hgbot (developer)
2022-11-29 12:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/985 [^]
(0144227)
hgbot (developer)
2022-11-29 12:28

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 0a3bdc23774f025260edfb1608289cd358b40542
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 29-11-2022 12:28:16
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/0a3bdc23774f025260edfb1608289cd358b40542 [^]

Fixed ISSUE-50112: Implement Pay Open Tickets in single payment refactor. Merge branch 'fr/50112'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/PayOpenTicketUsingCreditNote.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/PayOpenTicketsWithGiftCard.java
M src-test/org/openbravo/test/mobile/retail/pack/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/crossstore/CrossStorePaymentMultiple.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/crossstore/CrossStoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multichange/PayOpenTicketsMultiCurrency.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/prepaymentsAndInvoiceTerms/ImmediatePayOpenTicketsPrepayment270.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I35072_CorrectFinancialAccountWithPayOpen.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35778_VerifyPayOpenTicketPayments.java
---
(0144228)
hgbot (developer)
2022-11-29 12:28

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/246 [^]
(0144229)
hgbot (developer)
2022-11-29 12:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 2b9f6d71177d91801fc85a276ec4c9d9f58f02ec
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 29-11-2022 12:28:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/2b9f6d71177d91801fc85a276ec4c9d9f58f02ec [^]

Fixed ISSUE-50112: Implement Pay Open Tickets in single payment refactor. Merge branch 'fr/50112'

---
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/hooks/GiftCardHookUtils.java
---
(0144230)
hgbot (developer)
2022-11-29 12:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/172 [^]
(0144231)
hgbot (developer)
2022-11-29 12:29

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/36 [^]
(0144232)
hgbot (developer)
2022-11-29 12:29

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/48 [^]
(0144233)
hgbot (developer)
2022-11-29 12:29

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/32 [^]
(0144281)
hgbot (developer)
2022-12-01 06:50

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1003 [^]
(0144483)
hgbot (developer)
2022-12-07 14:45

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/248 [^]
(0144620)
hgbot (developer)
2022-12-14 08:16

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 36dae1d8a8a0617d233ccf6611a7e339d661a735
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 14-12-2022 07:16:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/36dae1d8a8a0617d233ccf6611a7e339d661a735 [^]

Related to ISSUE-50112. Added jest tests.

---
A web-test/model/business-object/ticket/actions/CompleteMultiTicketSinglePayment-combinedOrdersAmountNegative.test.js
A web-test/model/business-object/ticket/actions/CompleteMultiTicketSinglePayment-combinedOrdersAmountPositive.test.js
A web-test/model/business-object/ticket/actions/CompleteMultiTicketSinglePayment-combinedOrdersAmountZero.test.js
A web-test/model/business-object/ticket/actions/CompleteMultiTicketSinglePayment-multiPmntMethod.test.js
A web-test/model/business-object/ticket/actions/CompleteMultiTicketSinglePayment-onePmntMethod.test.js
M web-test/model/business-object/global/SetupGlobal.js
---
(0144621)
hgbot (developer)
2022-12-14 08:16

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1003 [^]
(0144622)
hgbot (developer)
2022-12-14 08:18

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 1d3f843010b3c15fbd3888eb287afc682890c9e4
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 14-12-2022 07:18:04
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/1d3f843010b3c15fbd3888eb287afc682890c9e4 [^]

Related to ISSUE-50112: Added JUnit tests to the new pay open ticket flow

---
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-multiorder-2-1.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-multiorder-2-2.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-multiorder-2-3.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-multiorder-2-4.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/message-order-multiorder-2-5.json
M src-test/org/openbravo/test/mobile/retail/pack/webservice/baseIntegration/BaseRetailOrderLoaderTest.java
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/RetailOrderLoaderTest.java
---
(0144623)
hgbot (developer)
2022-12-14 08:18

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/248 [^]

- Issue History
Date Modified Username Field Change
2022-08-30 13:05 jusanco New Issue
2022-08-30 13:05 jusanco Assigned To => Retail
2022-08-30 13:05 jusanco OBNetwork customer => No
2022-08-30 13:05 jusanco Triggers an Emergency Pack => No
2022-08-30 13:05 jusanco Issue generated from 0049895
2022-11-10 16:02 hgbot Merge Request Status => open
2022-11-10 16:02 hgbot Note Added: 0143416
2022-11-23 20:10 hgbot Note Added: 0144062
2022-11-28 11:05 marvintm Status new => scheduled
2022-11-28 11:05 marvintm Assigned To Retail => gaboflash
2022-11-29 12:17 hgbot Note Added: 0144221
2022-11-29 12:17 hgbot Note Added: 0144222
2022-11-29 12:17 hgbot Note Added: 0144223
2022-11-29 12:18 hgbot Note Added: 0144224
2022-11-29 12:28 hgbot Resolution open => fixed
2022-11-29 12:28 hgbot Status scheduled => resolved
2022-11-29 12:28 hgbot Fixed in Version => RR23Q1
2022-11-29 12:28 hgbot Note Added: 0144225
2022-11-29 12:28 hgbot Merge Request Status open => merged
2022-11-29 12:28 hgbot Note Added: 0144226
2022-11-29 12:28 hgbot Note Added: 0144227
2022-11-29 12:28 hgbot Note Added: 0144228
2022-11-29 12:28 hgbot Note Added: 0144229
2022-11-29 12:28 hgbot Note Added: 0144230
2022-11-29 12:29 hgbot Merge Request Status merged => approved
2022-11-29 12:29 hgbot Note Added: 0144231
2022-11-29 12:29 hgbot Note Added: 0144232
2022-11-29 12:29 hgbot Note Added: 0144233
2022-11-29 12:29 marvintm Review Assigned To => marvintm
2022-11-29 12:29 marvintm Status resolved => closed
2022-12-01 06:50 hgbot Note Added: 0144281
2022-12-07 14:45 hgbot Note Added: 0144483
2022-12-14 08:16 hgbot Note Added: 0144620
2022-12-14 08:16 hgbot Note Added: 0144621
2022-12-14 08:18 hgbot Note Added: 0144622
2022-12-14 08:18 hgbot Note Added: 0144623

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker