Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0050042

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 00. Application dictionary

major

always

2022-08-23 19:04

2022-09-16 13:47

Reporter

axelmercado

View Status

public

Assigned To

Triage Platform Base

Priority

high

Resolution

fixed

Fixed in Version

PR22Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

PR22Q1

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

PR22Q1

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Web browser

Google Chrome

Modules

User Interface Application

Support ticket

47998

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0050042: Bug after adding ad_image column in organization

Description

We have added a column of the type image in Organization and after adding it does not allow us to make changes in Organization
We get the following error:
The save action failed. Property organization does not exist for entity Organization

Steps To Reproduce

1-Create a new column of type image in the ad_org table
2-implement it in the application dictionary.
3-Attempt to complete a new record in Organization which will cause the error when saving.

Proposed Solution

Partner Practics has created a fix based on the following issue that is related to the problem:https://issues.openbravo.com/view.php?id=33934. [^]

He has adapted it to the new version. Attached is the patch.

Tags

No tags attached.

RemoveImagesEventHandler.diff [^] (1,107 bytes) 2022-08-23 19:04 [Show Content] [Hide Content]

--- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java	2022-08-23 17:20:57.270678000 +0200
+++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java	2022-08-23 11:08:04.861290000 +0200
@@ -128,14 +128,15 @@
   }
 
   public void onUpdate(@Observes EntityUpdateEvent event) {
-    if (!isValidEvent(event)) {
+    Entity entity = event.getTargetInstance().getEntity();
+    if (!isValidEvent(event) || !entity.hasProperty("organization")) {
       return;
     }
 
-    Property orgProperty = event.getTargetInstance().getEntity().getProperty("organization");
+    Property orgProperty = entity.getProperty("organization");
 
     // Iterate image properties of the entity
-    for (String property : getImageProperties(event.getTargetInstance().getEntity())) {
+    for (String property : getImageProperties(entity)) {
 
       Property imageProperty = event.getTargetInstance().getEntity().getProperty(property);
       Image bob = (Image) event.getPreviousState(imageProperty);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0141047) hgbot (developer) 2022-09-13 11:55	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/709 [^]

(0141189) hgbot (developer) 2022-09-16 13:47	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: ce7830686bf949626d42f01eaa766241c0fab086 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 16-09-2022 09:06:13 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ce7830686bf949626d42f01eaa766241c0fab086 [^] Fixes ISSUE-50042: image columns can be used in ad_org table The problem was that an event handler was taking for granted that all the tables it worked with were going to include a property named "organization". This is true for all entities except for the Organization entity itself. Now the event handler checks if the property exists before trying to retrieve it --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/RemoveImagesEventHandler.java ---

(0141190) hgbot (developer) 2022-09-16 13:47	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/709 [^]

Issue History
Date Modified	Username	Field	Change
2022-08-23 19:04	axelmercado	New Issue
2022-08-23 19:04	axelmercado	Assigned To	=> Triage Platform Base
2022-08-23 19:04	axelmercado	File Added: RemoveImagesEventHandler.diff
2022-08-23 19:04	axelmercado	OBNetwork customer	=> OBPS
2022-08-23 19:04	axelmercado	Web browser	=> Apple Safari
2022-08-23 19:04	axelmercado	Modules	=> User Interface Application
2022-08-23 19:04	axelmercado	Support ticket	=> 47998
2022-08-23 19:04	axelmercado	Triggers an Emergency Pack	=> No
2022-08-23 19:04	axelmercado	Web browser	Apple Safari => Google Chrome
2022-08-23 19:30	Practics	Issue Monitored: Practics
2022-09-13 11:55	hgbot	Merge Request Status	=> open
2022-09-13 11:55	hgbot	Note Added: 0141047
2022-09-16 13:46	hgbot	Merge Request Status	open => approved
2022-09-16 13:47	hgbot	Resolution	open => fixed
2022-09-16 13:47	hgbot	Status	new => closed
2022-09-16 13:47	hgbot	Fixed in Version	=> PR22Q4
2022-09-16 13:47	hgbot	Note Added: 0141189
2022-09-16 13:47	hgbot	Note Added: 0141190

Copyright © 2000 - 2009 MantisBT Group