Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050022 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-08-22 11:43 | 2022-09-15 09:00 | |||
| Reporter | jorgewederago | View Status | public | |||||
| Assigned To | radhakrishnan | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050022: Minumum characters configured in the backend for filters is not being taken into account in Search Customer to Assign Form | |||||||
| Description | In the backend, if we configure in the CRM Connector Filters minimum characters it is taken into account to show the form but not checked when pressing Search. However in the customer window it is working as expected | |||||||
| Steps To Reproduce | *Backend 1.-Configure a CRM Connector for the organization you are going to use 2.-Go to Filters in the CRM Connnector and set a minimum of characters for one of the properties which is bigger than 3 *POS2 1.-Open the Search and Assing window 2.-Write three characters in the field that was configured to have more than that 3.-Check that the search is executed even though it is not fulfilling the configuration Extra.- Check that any filter not configured to have a minimum does not allow the search with less than 3 fields | |||||||
| Proposed Solution | The code has a constant which has a minimum hardcoded. This should be changed to check each property minimum. CustomerSelectorHandler.js contains the following: const MINCHAR = 3; function isFieldWithNoMinLength The function must be modified to work as expected | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0140322) hgbot (developer) 2022-08-23 13:45 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1153 [^] |
|
(0140419) jorgewederago (viewer) 2022-08-26 10:23 |
While the solution is working as expected, it is required to remove the minimum of 3 characters since that hardcoded minimum is only being taken into account for that window while in the customer search it is following the definition of each field. |
|
(0141083) hgbot (developer) 2022-09-14 08:46 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1153 [^] |
|
(0141084) hgbot (developer) 2022-09-14 08:46 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 1c92e11682e42962f3a53a5e02169b0f645fc2f0 Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com> Date: 14-09-2022 06:46:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1c92e11682e42962f3a53a5e02169b0f645fc2f0 [^] Fixed ISSUE-50022: Added minimum character validation in customer search * If CRM enabled, minimum characters value should be validated when searching customer --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelectorHandler.js --- |
|
(0141137) hgbot (developer) 2022-09-15 08:53 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1205 [^] |
|
(0141141) hgbot (developer) 2022-09-15 09:00 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1205 [^] |
|
(0141142) hgbot (developer) 2022-09-15 09:00 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 534c14eb887dd76fd39eeba9f4fa51faa45f728e Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com> Date: 15-09-2022 12:17:48 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/534c14eb887dd76fd39eeba9f4fa51faa45f728e [^] Related ISSUE-50022: Added minCharacters in MockExternalBusinessPartnerConfig --- M web-jspack/org.openbravo.pos2/src/components/Customer/__mock__/MockExternalBusinessPartnerConfig.js M web-jspack/org.openbravo.pos2/src/components/Customer/__mock__/MockExternalBusinessPartnerListViewData.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-08-22 11:43 | jorgewederago | New Issue | |
| 2022-08-22 11:43 | jorgewederago | Assigned To | => Retail |
| 2022-08-22 11:43 | jorgewederago | OBNetwork customer | => No |
| 2022-08-22 11:43 | jorgewederago | Triggers an Emergency Pack | => No |
| 2022-08-22 12:12 | marvintm | Status | new => scheduled |
| 2022-08-22 12:12 | marvintm | Assigned To | Retail => radhakrishnan |
| 2022-08-23 13:45 | hgbot | Merge Request Status | => open |
| 2022-08-23 13:45 | hgbot | Note Added: 0140322 | |
| 2022-08-26 10:23 | jorgewederago | Note Added: 0140419 | |
| 2022-09-14 08:46 | hgbot | Merge Request Status | open => approved |
| 2022-09-14 08:46 | hgbot | Resolution | open => fixed |
| 2022-09-14 08:46 | hgbot | Status | scheduled => closed |
| 2022-09-14 08:46 | hgbot | Note Added: 0141083 | |
| 2022-09-14 08:46 | hgbot | Fixed in Version | => 22Q4 |
| 2022-09-14 08:46 | hgbot | Note Added: 0141084 | |
| 2022-09-15 08:53 | hgbot | Note Added: 0141137 | |
| 2022-09-15 09:00 | hgbot | Note Added: 0141141 | |
| 2022-09-15 09:00 | hgbot | Note Added: 0141142 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |