0049963: When a ImportEntry is not assigned to a runnable it should not be included in hte entryCount

Description

The ImportEntryProcessor.assignEntryToThread method might not assign the entry to a thread if there is a runnable of the previous search cycle still running.

When this happen the ImportEntryManager is still counting it in the entryCount counter that manages the wait time between cycles. This can generate extra wait time between cycles.

Steps To Reproduce

Create a big volume of slow import entries to force the system to execute a new search cycle when the previous runnables are still executing.

Notice that the import entries are not assigned to any threads but the calculated wait time to next search is considering all of them.

Proposed Solution

Change ImportEntryProcessor's handleImportEntry and assignEntryToThread methods to return a boolean.

assignEntryToThread return false when the ImportEntry is not assigned to a thread.

handleImportEntry returns false when the canHandleImportEntry or assignEntryToThread return false.

Change ImportEntryManager to update counter when the assignEntryToThread returns true.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0048427

closed

alostale

high load of low priority import entries can cause higher priority entries not to be processed

Notes
(0140080) hgbot (developer) 2022-08-12 08:02	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/680 [^]

Issue History
Date Modified	Username	Field	Change
2022-08-05 11:39	gorkaion	New Issue
2022-08-05 11:39	gorkaion	Assigned To	=> Triage Platform Base
2022-08-05 11:39	gorkaion	Modules	=> Core
2022-08-05 11:39	gorkaion	Triggers an Emergency Pack	=> No
2022-08-12 07:57	alostale	Status	new => acknowledged
2022-08-12 08:02	hgbot	Note Added: 0140080
2022-08-12 10:36	alostale	Relationship added	related to 0048427