Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049918 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-08-01 09:50 | 2022-08-12 10:43 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | Triage Platform Base | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049918: npm install generates changes by default | |||||||
| Description | By default, since the update to node 16 and npm 8, when npm install is executed, there are changes in package-lock.json file. This is due to a flag that is required but not enforced, which is --legacy-peer-deps. Executing npm install --legacy-peer-deps does not generate changes on package-lock.json file. | |||||||
| Steps To Reproduce | 1. Have an openbravo environment locally 2. Run npm install command Check that there are changes in package-lock.json 3. Run npm install --legacy-peer-deps Check that there are no changes in package-lock.json | |||||||
| Proposed Solution | Create a new file .npmrc at openbravo root level, and include in it the following line: legacy-peer-deps=true This will enforce the flag when we run npm install from the main openbravo directory. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0139758) hgbot (developer) 2022-08-01 09:54 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/660 [^] |
|
(0140084) hgbot (developer) 2022-08-12 10:43 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: d7549d36aadff6199f14a05d5dee8c55aff60071 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 12-08-2022 08:38:27 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d7549d36aadff6199f14a05d5dee8c55aff60071 [^] Fixes ISSUE-49918: npm install generates changes by default To fix this, an .npmrc file has been added, which enforces the --legacy-peer-deps flag to be added on the npm install executed from the openbravo root directory. This makes sure there are no changes on the package-lock.json file --- A .npmrc --- |
|
(0140085) hgbot (developer) 2022-08-12 10:43 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/660 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-08-01 09:50 | cberner | New Issue | |
| 2022-08-01 09:50 | cberner | Assigned To | => Triage Platform Base |
| 2022-08-01 09:50 | cberner | Modules | => Core |
| 2022-08-01 09:50 | cberner | Triggers an Emergency Pack | => No |
| 2022-08-01 09:54 | hgbot | Note Added: 0139758 | |
| 2022-08-12 10:43 | hgbot | Resolution | open => fixed |
| 2022-08-12 10:43 | hgbot | Status | new => closed |
| 2022-08-12 10:43 | hgbot | Fixed in Version | => PR22Q4 |
| 2022-08-12 10:43 | hgbot | Note Added: 0140084 | |
| 2022-08-12 10:43 | hgbot | Note Added: 0140085 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |