0049858: Add association to service request doesn't filter out orderlines that can't be associated

Description

When adding associations to a service product, a popup appears that shows the order lines that can be associated to the selected service. This list shows order lines that do not have the given product configured to it, so that means it shows order lines that shouldn't appear.

This is a regression from WebSQL change to indexeddb, as previously it was working correctly.

Steps To Reproduce

1. Connect and login on WebPOS
2. Add a GPS Handheld product
3. Click on services button, and add an Installation Pack product
4. Click on installation pack, and on top right, select Add Associations option
5. Click on filter, check that there are order lines that shouldn't appear, for example Avalanche Transceiver.

A couple gifs have been provided with correct behaviour(pre-regression) and incorrect behaviour.

Proposed Solution

In AssociateOrderLines.java hql query, it is assumed that some filters from backend have values 'Y' or 'N', but since the change of WebSQL, this values are now false/true, so should be handled as so on the corresponding filtering.

Tags

No tags attached.

Attached Files

wrong behaviour add association query.gif [^] (799,224 bytes) 2022-07-20 15:02

correct behaviour add association query.gif [^] (435,723 bytes) 2022-07-20 15:04

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0139530) hgbot (developer) 2022-07-22 08:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/870 [^]

(0140640) hgbot (developer) 2022-09-04 08:41	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/870 [^]

(0140641) hgbot (developer) 2022-09-04 08:41	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: ad62c1ee2b1984d1e2e2904e3be71d0732ab387b Author: Ranjith S R <ranjith@qualiantech.com> Date: 04-09-2022 06:41:11 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ad62c1ee2b1984d1e2e2904e3be71d0732ab387b [^] Fixed ISSUE-49858: Updated Association Filter to use boolean value in service product filter --- M src/org/openbravo/retail/posterminal/AssociateOrderLines.java ---

Issue History
Date Modified	Username	Field	Change
2022-07-20 15:02	cberner	New Issue
2022-07-20 15:02	cberner	Assigned To	=> Retail
2022-07-20 15:02	cberner	File Added: wrong behaviour add association query.gif
2022-07-20 15:02	cberner	Triggers an Emergency Pack	=> No
2022-07-20 15:04	cberner	Regression level	=> Production - Confirmed Stable
2022-07-20 15:04	cberner	Regression date	=> 2020-08-10
2022-07-20 15:04	cberner	Regression introduced in release	=> RR20Q3
2022-07-20 15:04	cberner	File Added: correct behaviour add association query.gif
2022-07-21 11:23	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2022-07-21 11:23	ranjith_qualiantech_com	Status	new => scheduled
2022-07-22 08:48	hgbot	Note Added: 0139530
2022-09-04 08:41	hgbot	Resolution	open => fixed
2022-09-04 08:41	hgbot	Status	scheduled => closed
2022-09-04 08:41	hgbot	Fixed in Version	=> RR22Q4
2022-09-04 08:41	hgbot	Note Added: 0140640
2022-09-04 08:41	hgbot	Note Added: 0140641