Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049720 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Restaurants | critical | always | 2022-06-27 15:29 | 2022-10-06 14:45 | |||
| Reporter | timothee_catteeuw | View Status | public | |||||
| Assigned To | ablasco | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q3.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 22Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049720: JIRA 3109 - Performance issues when updating keymap through keymap editor | |||||||
| Description | When a modification is done thanks to Keymap editor, those one are correctly shared with other tills but : - update process is really long (several seconds as you can in video attached to the Jira) If someone apply a modification in Keymap editor, it can impact a cashier is working on another till during around 10 sec. - No loader is displayed, the user doesn’t know what is waiting for - moreover it happen even if the cashier is working on a ticket and he is forced to wait for the end of the process in order to continue his ticket. It would be more proper to update the key map when the cashier start a new ticket (or when he finish and pay the one he is working on) | |||||||
| Steps To Reproduce | Go to WebPos Open keymap editor Open the layout option for the default keymap you are used to (because it is the first it will be displayed when you go to "sell" screen) Change something on it (change the number of product) and click save Quickly go to the "sell" screen --> The user has to wait between 5 and 10 sec before working again --> no loader message is displayed | |||||||
| Proposed Solution | - analyze optimization when importing keymap data on till - display a loader message - analyze the possibility of an asynchronous update, for exemple → if possible not allow importing and updating keymap modifications when the cashier is working on a ticket and wait that the current ticket is paid before updating data. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0139069) hgbot (developer) 2022-07-05 10:53 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1070 [^] |
|
(0139070) hgbot (developer) 2022-07-05 10:58 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/794 [^] |
|
(0139116) hgbot (developer) 2022-07-06 09:21 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 3a4e2891b0a8fca1e24ff8296cf9c03d82dfc7bc Author: adrian.blasco <adrian.blasco@openbravo.com> Date: 06-07-2022 06:50:36 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3a4e2891b0a8fca1e24ff8296cf9c03d82dfc7bc [^] Fixes ISSUE-49720: Improve performance after saving a change in the keymap editor Before this change, when saving a change in the keymap editor for a given keymap, all keymaps were being recomputed. Now only the keymap being edited will be recomputed, the configuration for the rest will be reused from the current version of the configuration. This change relies on the core2 change that provides the previous version of a configuration when the new one is being computed. Also Fixes ISSUE 49709 Avoid Empty Screen in KeymapEditor when save from Back button copyright --- M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapOnExitPopup/KeymapOnExitPopup.js M web-jspack/org.openbravo.pos2/src/configurations/keymapConfiguration/loadKeymapConfigurations.js --- |
|
(0139117) hgbot (developer) 2022-07-06 09:21 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1070 [^] |
|
(0139118) hgbot (developer) 2022-07-06 09:21 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 20854fa08afd8b6c9f8a39163b509b2b4693ea8c Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 05-07-2022 10:57:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/20854fa08afd8b6c9f8a39163b509b2b4693ea8c [^] Related to ISSUE-49720: Previous configuration is available while new version if being computed It is convenient to have the previous version of a configuration while the one is being computed, i.e. to reuse some configurations and recreate only some others --- M web-jspack/org.openbravo.core2/src/core/ConfigurationSet.js M web-jspack/org.openbravo.core2/src/core/Registry.js --- |
|
(0139119) hgbot (developer) 2022-07-06 09:21 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/794 [^] |
|
(0141740) hgbot (developer) 2022-10-06 14:45 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 5c266373fd20e52e1a51a92a9afb65e924b230ab Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 06-10-2022 12:45:46 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5c266373fd20e52e1a51a92a9afb65e924b230ab [^] Fixes ISSUE-49720: Improve performance after saving a change in the keymap editor --- M src/org/openbravo/pos2/KeymapLoader.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-07-04 14:51 | cberner | Type | defect => backport |
| 2022-07-04 14:51 | cberner | Target Version | => 22Q3.1 |
| 2022-07-05 08:37 | guilleaer | Target Version | 22Q3.1 => 22Q3 |
| 2022-07-05 10:53 | hgbot | Note Added: 0139069 | |
| 2022-07-05 10:58 | hgbot | Note Added: 0139070 | |
| 2022-07-05 13:10 | ablasco | Relationship added | related to 0049734 |
| 2022-07-06 09:21 | hgbot | Resolution | open => fixed |
| 2022-07-06 09:21 | hgbot | Status | scheduled => closed |
| 2022-07-06 09:21 | hgbot | Note Added: 0139116 | |
| 2022-07-06 09:21 | hgbot | Note Added: 0139117 | |
| 2022-07-06 09:21 | hgbot | Note Added: 0139118 | |
| 2022-07-06 09:21 | hgbot | Note Added: 0139119 | |
| 2022-10-06 14:45 | hgbot | Fixed in Version | => 22Q3.2 |
| 2022-10-06 14:45 | hgbot | Note Added: 0141740 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |