Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049628
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Retail APImajoralways2022-06-22 15:282022-07-26 08:16
Reporterazzeddine_meftohView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR22Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049628: External Order Loader - impossible to import return line with a negative line gross amount

DescriptionWhen importing orders with return line through the external order loader we cannot push a negative value on the line gross amount

(FYI : when doing returns on the pos this field is negative)
Steps To Reproducepost on order with a return line -> absolute value in the DB
The issue can be reproduced using the "Import Order - Return" example from the Openbravo API Postman suite, or using the attached json.
Proposed SolutionThe problem happens because the External Order Loader always sets the lineGrossAmount value with an absolute value[1], forcing all imported lines to be positive.

This seems to be a regression added with the project to support the Cancel Layaway flow from the EOL in 20q4

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java#L856 [^]


Attached a patch with a possible solution: keep the absolute value when doing a Cancel via EOL, otherwise use the gross amount (as it was used before 20q4).
TagsFASH
Attached Files? file icon 49628.json [^] (919 bytes) 2022-06-22 16:08
diff file icon 49628_patch.diff [^] (1,362 bytes) 2022-06-22 16:09 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0049472 closedrqueralta Error with OrderLoader Web Services 

-  Notes
(0138898)
hgbot (developer)
2022-07-01 09:03

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/839 [^]
(0139565)
hgbot (developer)
2022-07-25 08:53

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/839 [^]
(0139566)
hgbot (developer)
2022-07-25 08:53

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9bdbd96e64488076a4530c7f593b61e0cd21b0fb
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 25-07-2022 06:53:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9bdbd96e64488076a4530c7f593b61e0cd21b0fb [^]

Fixed ISSUE-49628: LineGrossAmount should be same as GrossAmount in EOL
* in EOL, If order is CANCEL, then lineGrossAmount should be updated as positive

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0139601)
hgbot (developer)
2022-07-26 08:16

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 394be9b2bfb3ec4c930cebe9e68c791d1a6cc0af
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 26-07-2022 11:45:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/394be9b2bfb3ec4c930cebe9e68c791d1a6cc0af [^]

Related to ISSUE-49628: LineJson orderStep should be updated after product validation in EOL

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---

- Issue History
Date Modified Username Field Change
2022-06-22 15:28 azzeddine_meftoh New Issue
2022-06-22 15:28 azzeddine_meftoh Assigned To => Triage Platform Conn
2022-06-22 15:28 azzeddine_meftoh Triggers an Emergency Pack => No
2022-06-22 15:58 aaroncalero Assigned To Triage Platform Conn => Retail
2022-06-22 15:58 aaroncalero Summary order loader - impossible to import return line with a negative line gross amount => External Order Loader - impossible to import return line with a negative line gross amount
2022-06-22 15:58 aaroncalero Description Updated View Revisions
2022-06-22 16:08 aaroncalero Steps to Reproduce Updated View Revisions
2022-06-22 16:08 aaroncalero Proposed Solution updated
2022-06-22 16:08 aaroncalero File Added: 49628.json
2022-06-22 16:09 aaroncalero File Added: 49628_patch.diff
2022-06-22 17:44 marvintm Relationship added related to 0049472
2022-06-23 11:51 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2022-06-24 11:23 ranjith_qualiantech_com Status new => scheduled
2022-07-01 09:03 hgbot Note Added: 0138898
2022-07-01 09:55 rafaroda Tag Attached: FASH
2022-07-25 08:53 hgbot Resolution open => fixed
2022-07-25 08:53 hgbot Status scheduled => closed
2022-07-25 08:53 hgbot Note Added: 0139565
2022-07-25 08:53 hgbot Fixed in Version => RR22Q4
2022-07-25 08:53 hgbot Note Added: 0139566
2022-07-26 08:16 hgbot Note Added: 0139601

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker