Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0049551 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] 04. Warehouse management | major | always | 2022-06-14 11:51 | 2022-07-26 11:25 | |||
Reporter | gorkaion | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | high | Resolution | fixed | Fixed in Version | PR22Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | Gold | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | 42835 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0049551: No storage detail automatically removed when the product does not have attribute set | |||||||
Description | The m_update_inventory process is removing from the system the storage details with all the quantities in zero. There is an exception when the product has an attribute set defined as Specification and the attribute set has the flag to require at least one value disabled. There is a bug implementing the exception as it does a full join to the attribute set. So it only consider for deletion products using attributes. | |||||||
Steps To Reproduce | Failure test: - Create a product that does not use attributes - Create a shipment line with that product (leave in draft the shipment). - Check in the database that a storage detail is created. - Delete the shipment line - Check in the database that the storage detail is not deleted. Working test: - Create a product and set an attribute set that has the require at least one value flag enabled. and leave the "use attribute set value as" field empty. - Create a shipment line with that product (leave in draft the shipment). - Check in the database that a storage detail is created. - Delete the shipment line - Check in the database that the storage detail is deleted. | |||||||
Proposed Solution | modify the query to use a left join on attribute set table. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
||||||||
|
![]() |
|
(0139294) mtaal (viewer) 2022-07-13 10:29 |
Solution: if a product does not have an attribute set and the storage detail has quantity zero then the storage detail should be deleted as well. |
(0139381) hgbot (developer) 2022-07-18 11:53 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/649 [^] |
(0139439) hgbot (developer) 2022-07-20 09:01 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/649 [^] |
(0139440) hgbot (developer) 2022-07-20 09:01 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 0e2fd06e1575744fb12ed5fc0494ed239e4a29f9 Author: Sandra Huguet <sandra.huguet@openbravo.com> Date: 20-07-2022 07:00:27 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0e2fd06e1575744fb12ed5fc0494ed239e4a29f9 [^] Fixed ISSUE-49551 storagedetail automatically removed when the product does not have attributeset --- M src-db/database/model/functions/M_UPDATE_INVENTORY.xml --- |
(0139604) hgbot (developer) 2022-07-26 11:25 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^] Changeset: baf8c5dfd172f5d04a86a639786a2f738de5c1b1 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 26-07-2022 14:51:29 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/baf8c5dfd172f5d04a86a639786a2f738de5c1b1 [^] Related to BUG-0049551: No storage detail automatically removed when the product does not have attribute set **In the test data, storage detail for product without attribute is not found hence before assertion make sure qtyOnHand is greater than zero so that storage detail exists. **Handle NPE in case storage detail is null. --- M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOri_ReferencedInventoryBoxTest.java M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/ici/AWOici_WeldBaseTest.java --- |
![]() |
|||
Date Modified | Username | Field | Change |
2022-06-14 11:51 | gorkaion | New Issue | |
2022-06-14 11:51 | gorkaion | Assigned To | => Triage Omni WMS |
2022-06-14 11:51 | gorkaion | OBNetwork customer | => No |
2022-06-14 11:51 | gorkaion | Modules | => Core |
2022-06-14 11:51 | gorkaion | Support ticket | => 42835 |
2022-06-14 11:51 | gorkaion | Triggers an Emergency Pack | => No |
2022-06-28 09:25 | gorkaion | OBNetwork customer | No => Gold |
2022-07-13 10:29 | mtaal | Note Added: 0139294 | |
2022-07-13 10:30 | mtaal | Assigned To | Triage Omni WMS => mtaal |
2022-07-18 11:53 | hgbot | Merge Request Status | => open |
2022-07-18 11:53 | hgbot | Note Added: 0139381 | |
2022-07-20 09:01 | hgbot | Merge Request Status | open => approved |
2022-07-20 09:01 | hgbot | Resolution | open => fixed |
2022-07-20 09:01 | hgbot | Status | new => closed |
2022-07-20 09:01 | hgbot | Note Added: 0139439 | |
2022-07-20 09:01 | hgbot | Fixed in Version | => PR22Q4 |
2022-07-20 09:01 | hgbot | Note Added: 0139440 | |
2022-07-26 11:25 | hgbot | Note Added: 0139604 | |
2022-11-15 17:07 | vmromanos | Relationship added | related to 0050776 |
Copyright © 2000 - 2009 MantisBT Group |