Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049517
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2022-06-09 09:492022-07-19 06:45
ReporterrfaconView Statuspublic 
Assigned Toradhakrishnan 
PrioritynormalResolutionfixedFixed in VersionRR22Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049517: API call - Availability of a promotion is calculated on universal time by the API

DescriptionWhen configuring the availability subtab of a promotion using hours filters in the Back Office, this promotion is wrongly applied when a call is done on API Discount
Steps To Reproduce1. Configure a discount in the Backend, for example:
- Discount/Promotion Type: Price adjustment
- Active = Y
- Define the discount for a product, for example Baby carrier and select "Included Products" = Only those defined.

2. In the subtab 'Availability' add a row: define 'Monday' from '0:00:00' to '23:59:59'

3. Call the API Discount https://{{OPENBRAVO_URL}}/openbravo/ws/org.openbravo.discounts.discount [^] with the product put at step 1 and an order date set on a Monday, "orderDate": "2022-06-06T13:59:00" for example

You will see the discount applied as configured.

4. Change the hour of the 'orderDate" doing several calls :
- "orderDate": "2022-06-06T23:00:00" (Monday)
- "orderDate": "2022-06-05T23:00:00" (Sunday)

In the summer time for France ("orderDate": "2022-06-06") you will see the discount applied from 'Sunday 22:00:00' to 'Monday 21:59:59' (UTC+2)

In the winter time for France ("orderDate": "2022-03-07") you will see the discount applied from 'Sunday 23:00:00' to 'Monday 22:59:59' (UTC+1)

An example of API Discount call is set in attachements
TagsNOR
Attached Filestxt file icon Exemple of call API Discount.txt [^] (440 bytes) 2022-06-09 09:49 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0048383pi closedjetxarri Allow to activate promotions on 2 distinct time slots within the same day 
related to defect 0049204 closedranjith_qualiantech_com Modifying the Availibility subtab doesn't update the discount audit section 
related to defect 0049195 closedradhakrishnan Availability subtab records can be deleted 
related to defect 0049194 closedradhakrishnan Discount availability should be validated with POS time instead of server time 
related to defect 0049518 closedradhakrishnan API call - A promotion with an availability set on the last hours of a day is also applied on the last hours of the day before 

-  Notes
(0138660)
hgbot (developer)
2022-06-23 07:37

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/58 [^]
(0139398)
hgbot (developer)
2022-07-19 06:45

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 25f475583e5125d3e6794faa515ef9ac6e14a968
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 19-07-2022 04:45:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/25f475583e5125d3e6794faa515ef9ac6e14a968 [^]

Fixed ISSUE-49517: Validated the availabilty date with current date

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---
(0139399)
hgbot (developer)
2022-07-19 06:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/58 [^]

- Issue History
Date Modified Username Field Change
2022-06-09 09:49 rfacon New Issue
2022-06-09 09:49 rfacon Assigned To => Retail
2022-06-09 09:49 rfacon File Added: Exemple of call API Discount.txt
2022-06-09 09:49 rfacon Triggers an Emergency Pack => No
2022-06-09 23:39 rafaroda Tag Attached: NOR
2022-06-09 23:40 rafaroda Relationship added related to 0049518
2022-06-09 23:41 rafaroda Relationship added related to 0048383
2022-06-09 23:43 rafaroda Relationship added related to 0049204
2022-06-09 23:44 rafaroda Relationship added related to 0049195
2022-06-09 23:45 rafaroda Relationship added related to 0049194
2022-06-21 13:38 radhakrishnan Assigned To Retail => radhakrishnan
2022-06-21 13:39 radhakrishnan Status new => scheduled
2022-06-23 07:37 hgbot Note Added: 0138660
2022-07-19 06:45 hgbot Resolution open => fixed
2022-07-19 06:45 hgbot Status scheduled => closed
2022-07-19 06:45 hgbot Fixed in Version => RR22Q4
2022-07-19 06:45 hgbot Note Added: 0139398
2022-07-19 06:45 hgbot Note Added: 0139399


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker