Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049285
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2022-05-10 17:122022-05-11 08:41
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in VersionPR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049285: DB transaction is left opened after executing the test connectivity process

DescriptionAfter executing the test connectivity process for an HTTP external system, a DB transaction is left opened
Steps To Reproduce1) Login
2) Execute the query: select count(*) from pg_stat_activity where state ilike '%in transaction%'; --> count result is 0
3) Go to the External System window, create a new HTTP external system with all the required information
4) Click on the "Test" button
5) Execute the query again: select count(*) from pg_stat_activity where state ilike '%in transaction%'; --> WRONG: now count result is 1
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0048579 closedcaristu Push API 

-  Notes
(0137134)
hgbot (developer)
2022-05-10 17:36

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/591 [^]
(0137136)
hgbot (developer)
2022-05-11 07:52

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/591 [^]
(0137137)
hgbot (developer)
2022-05-11 07:52

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: deb8e248c0233e75f7c9e0dfde6f6cc5bb58b933
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 10-05-2022 15:42:40
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/deb8e248c0233e75f7c9e0dfde6f6cc5bb58b933 [^]

fixes BUG-49285: test connectivity process leaves an opened DB transaction

  In the test connectivity process we are making use of the thenApply
method of the CompletableFuture returned by the External System API to
build the process result with the information coming from the send
method.

  Altough we are consuming this API in a synchronous way, our lambda
executed in the thenApply is executed in a separate thread which is
making use of DAL to get the AD messages that are included in the
process result.

  For this reason we have to manually close the DAL connection
(transaction) in our lambda as this thread will not by controlled by the
standard flow which makes use of the DalThreadFilter to close the
connections.

---
M src/org/openbravo/service/externalsystem/process/CheckConnectivity.java
---

- Issue History
Date Modified Username Field Change
2022-05-10 17:12 caristu New Issue
2022-05-10 17:12 caristu Assigned To => caristu
2022-05-10 17:12 caristu Modules => Core
2022-05-10 17:12 caristu Triggers an Emergency Pack => No
2022-05-10 17:36 hgbot Note Added: 0137134
2022-05-10 17:37 caristu Relationship added caused by 0048579
2022-05-11 07:52 hgbot Note Added: 0137136
2022-05-11 07:52 hgbot Resolution open => fixed
2022-05-11 07:52 hgbot Status new => closed
2022-05-11 07:52 hgbot Fixed in Version => PR22Q3
2022-05-11 07:52 hgbot Note Added: 0137137
2022-05-11 08:41 alostale Severity minor => major

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker