Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0049280

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

have not tried

2022-05-10 14:18

2022-05-25 09:05

Reporter

collazoandy4

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR22Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0049280: NPE en PaidReceipts when is called from OpenRelatedReceipts

Description

When the PaidReceipts process is called from OpenRelatedReceipts process a NPE is raise if the order payment has a different financial account than the one defined in the Touchpoint

Steps To Reproduce

As White Valley Group Admin log in the backoffice
  Go to Issuing Company and select Restaurant Check record
    Set Gift Card Financial Account - EUR as Finnancial Account in Accounts tab
  Navigate to the finnancial account
  Create a new record in Payment Method tab:
    Payment Method: Wire Transfer
    Automatic Deposit: Y
  Go to Touchpoint type window and update YS POS Terminal Type record:
    Open related receipts: Y
  Log In YS-11 Pos terminal
    Select Carl Studson as customer
    Set the receipt as layaway
    Add Avalanche transceiver product
    Add a new Digital coupon payment:
      Issuing company: 'Restaurant Check'
      Check Number: 12345
      Amount: 20
      Expiration date: Next Month
    Syncronize the receipt as with the backend

    Create a new layaway for Carl Studon
    Add Balaclava cap product
    Syncronize the receipt as with the backend

    Open the last layway created and check Open Related receipt popup is shown
    Select the first layway created and check a NPE is raise in PaidReceipts.java because the posterminal object is null

Proposed Solution

Add a null check to posTerminal var in PaidReceipts

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0137355) hgbot (developer) 2022-05-16 21:21	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/799 [^]

(0137703) hgbot (developer) 2022-05-25 09:05	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 181719afedf7da4d09de51f9987c7b3087a6465e Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 25-05-2022 07:04:49 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/181719afedf7da4d09de51f9987c7b3087a6465e [^] Fixed BUG-49280: checked id posTerminal var is null before call executePaidReceiptsPaymentTypeTerminalHooks funtion --- M src/org/openbravo/retail/posterminal/PaidReceipts.java ---

(0137704) hgbot (developer) 2022-05-25 09:05	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/799 [^]

Issue History
Date Modified	Username	Field	Change
2022-05-10 14:18	collazoandy4	New Issue
2022-05-10 14:18	collazoandy4	Assigned To	=> Retail
2022-05-10 14:18	collazoandy4	Triggers an Emergency Pack	=> No
2022-05-11 05:56	rqueralta	Assigned To	Retail => rqueralta
2022-05-11 05:56	rqueralta	Status	new => scheduled
2022-05-16 21:21	hgbot	Note Added: 0137355
2022-05-25 09:04	hgbot	Resolution	open => fixed
2022-05-25 09:04	hgbot	Status	scheduled => closed
2022-05-25 09:05	hgbot	Fixed in Version	=> RR22Q3
2022-05-25 09:05	hgbot	Note Added: 0137703
2022-05-25 09:05	hgbot	Note Added: 0137704

Copyright © 2000 - 2009 MantisBT Group