Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0049264
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2022-04-08 11:192022-05-31 10:31
ReporteralostaleView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in VersionPR22Q2.1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR22Q2.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049264: remove obsolete Translation Required field from Module window

DescriptionTranslation required field is present in Module window, it is never used so it could be removed.

Together with it there is a validation to ensure modules with "UI artifacts" mark this flag. This validation should also be removed as it provides no value.
Steps To Reproduce1. Create a module with the Translation Required flag unchecked
2. Create a new window for that module
3. Run validations
  -> It complains about that module not being marked as translation required
Proposed Solution1. Remove the field from Module window
2. Remove checkUIArtifacts from ModuleValidator [1]
3. Deprecate the column in AD
   We'll keep the column to prevent a formal change when exporting every module


[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/system/ModuleValidator.java#L186 [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0049011PR22Q3 closedmeriem_azaf remove obsolete Translation Required field from Module window 

-  Notes
(0137853)
hgbot (developer)
2022-05-30 13:19

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/606 [^]
(0137873)
hgbot (developer)
2022-05-31 10:30

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 71db165cf7ef71a7e81d4bc604cfccfbde22cdd3
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 30-05-2022 13:16:59
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/71db165cf7ef71a7e81d4bc604cfccfbde22cdd3 [^]

Fixes ISSUE-49264: Remove obsolete Translation Required field from Module window

The problem that creating a new module with the translation required flag unchecked and create also a new window for that module after running the validatio it complains about that module not being marked as translation required.

To fix this, we removed the field translation required from Module window and also the function checkUIArtifacts from ModuleValidator. we deprecated the column in AD.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/CreateCustomModule.java
M src/org/openbravo/service/system/ModuleValidator.java
---
(0137874)
hgbot (developer)
2022-05-31 10:30

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/606 [^]

- Issue History
Date Modified Username Field Change
2022-05-09 13:04 AugustoMauch Type defect => backport
2022-05-09 13:04 AugustoMauch Target Version PR22Q3 => PR22Q2.1
2022-05-30 13:19 hgbot Note Added: 0137853
2022-05-31 10:30 hgbot Resolution open => fixed
2022-05-31 10:30 hgbot Status scheduled => closed
2022-05-31 10:30 hgbot Fixed in Version => PR22Q2.1
2022-05-31 10:30 hgbot Note Added: 0137873
2022-05-31 10:30 hgbot Note Added: 0137874
2022-05-31 10:31 cberner Fixed in SCM revision asdf =>


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker