Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049264Openbravo ERPA. Platformpublic2022-04-08 11:192022-05-31 10:31
Reporteralostale 
Assigned Tomeriem_azaf 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR22Q2.1Fixed in VersionPR22Q2.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049264: remove obsolete Translation Required field from Module window
DescriptionTranslation required field is present in Module window, it is never used so it could be removed.

Together with it there is a validation to ensure modules with "UI artifacts" mark this flag. This validation should also be removed as it provides no value.
Steps To Reproduce1. Create a module with the Translation Required flag unchecked
2. Create a new window for that module
3. Run validations
  -> It complains about that module not being marked as translation required
Proposed Solution1. Remove the field from Module window
2. Remove checkUIArtifacts from ModuleValidator [1]
3. Deprecate the column in AD
   We'll keep the column to prevent a formal change when exporting every module


[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/system/ModuleValidator.java#L186 [^]
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0049011PR22Q3 closed meriem_azaf remove obsolete Translation Required field from Module window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-09 13:04AugustoMauchTypedefect => backport
2022-05-09 13:04AugustoMauchTarget VersionPR22Q3 => PR22Q2.1
2022-05-30 13:19hgbotNote Added: 0137853
2022-05-31 10:30hgbotResolutionopen => fixed
2022-05-31 10:30hgbotStatusscheduled => closed
2022-05-31 10:30hgbotFixed in Version => PR22Q2.1
2022-05-31 10:30hgbotNote Added: 0137873
2022-05-31 10:30hgbotNote Added: 0137874
2022-05-31 10:31cbernerFixed in SCM revisionasdf =>

Notes
(0137853)
hgbot   
2022-05-30 13:19   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/606 [^]
(0137873)
hgbot   
2022-05-31 10:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 71db165cf7ef71a7e81d4bc604cfccfbde22cdd3
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 30-05-2022 13:16:59
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/71db165cf7ef71a7e81d4bc604cfccfbde22cdd3 [^]

Fixes ISSUE-49264: Remove obsolete Translation Required field from Module window

The problem that creating a new module with the translation required flag unchecked and create also a new window for that module after running the validatio it complains about that module not being marked as translation required.

To fix this, we removed the field translation required from Module window and also the function checkUIArtifacts from ModuleValidator. we deprecated the column in AD.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/CreateCustomModule.java
M src/org/openbravo/service/system/ModuleValidator.java
---
(0137874)
hgbot   
2022-05-31 10:30   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/606 [^]