Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049226 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-05-05 11:09 | 2022-05-06 10:51 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | PR22Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049226: matchesObject should fail if there are missing properties in actual | |||||||
| Description | Given: actual = { p1: 1, p2: 2, p4: 4 } expected = { p1: 1, p2: 2, p3: 3 } Then: assertThat(actual, matchesObject(expected)) must be false. But currently this is not being asserted correctly as it returns true because when having the same number of properties only the common properties (p1 and p2 in this example) are taken into account. | |||||||
| Steps To Reproduce | . | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0136968) hgbot (developer) 2022-05-05 11:12 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/583 [^] |
|
(0136985) hgbot (developer) 2022-05-05 16:43 |
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^] Changeset: cd8d2f253e907cb955ddc0abf901c9db1d795899 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 05-05-2022 15:52:14 URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/cd8d2f253e907cb955ddc0abf901c9db1d795899 [^] related to BUG-49226: fix tests failing due to missing props --- M src-test/data/export/filter/product/ProductByComplementaryProduct.json M src-test/data/export/filter/product/ProductByMultiUPC.json --- |
|
(0137018) hgbot (developer) 2022-05-06 10:51 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/583 [^] |
|
(0137019) hgbot (developer) 2022-05-06 10:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: d7eef69a7a2e50db561e2e3446d6eeb91b469ac4 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 06-05-2022 08:51:14 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d7eef69a7a2e50db561e2e3446d6eeb91b469ac4 [^] fixes BUG-49226: matchesObject should fail if there are missing props in actual --- M src-test/src/org/openbravo/test/matchers/json/JSONMatcher.java M src-test/src/org/openbravo/test/matchers/json/JSONMatchersTest.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-05-05 11:09 | caristu | New Issue | |
| 2022-05-05 11:09 | caristu | Assigned To | => caristu |
| 2022-05-05 11:09 | caristu | Modules | => Core |
| 2022-05-05 11:09 | caristu | Triggers an Emergency Pack | => No |
| 2022-05-05 11:09 | caristu | Issue generated from | 0049170 |
| 2022-05-05 11:09 | caristu | Relationship added | related to 0049170 |
| 2022-05-05 11:11 | caristu | Summary | matchesObject should fail if there are properties missing in actual => matchesObject should fail if there are missing properties in actual |
| 2022-05-05 11:12 | hgbot | Note Added: 0136968 | |
| 2022-05-05 16:43 | hgbot | Note Added: 0136985 | |
| 2022-05-06 10:51 | hgbot | Resolution | open => fixed |
| 2022-05-06 10:51 | hgbot | Status | new => closed |
| 2022-05-06 10:51 | hgbot | Note Added: 0137018 | |
| 2022-05-06 10:51 | hgbot | Fixed in Version | => PR22Q3 |
| 2022-05-06 10:51 | hgbot | Note Added: 0137019 | |
| 2022-05-18 11:41 | caristu | Relationship deleted | related to 0049170 |
| 2022-05-18 11:41 | caristu | Relationship added | related to 0048373 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |