Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049111
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsminorhave not tried2022-04-22 11:252022-05-10 09:45
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionRR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049111: Discounts tests with node server fail due to usage of Dal

DescriptionDal is being used in several tests on Discounts module. This results in them failing when tested in Remote mode, with the node server deployed. That is due to Dal not being initialized on all tests, it is only initialized once at the start for deploying the JS and then it is assumed not required by the testing infrastructure, that is not the case anymore, as Dal is being used in several tests.
Steps To ReproduceFollow the guide provided here: http://wiki.openbravo.com/wiki/How_to_run_Discounts_Test_Cases#Running_the_test_cases [^]

Run the tests in Remote mode and check that all tests fail after the first test-case, due to Dal being uninitialized. If rerun with the node service not restarted, all tests will fail, as dal is not initialized.
Proposed SolutionInitialize Dal always at the start of the suite of tests.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0136676)
hgbot (developer)
2022-04-22 11:28

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/54 [^]
(0137109)
hgbot (developer)
2022-05-10 09:45

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/54 [^]
(0137110)
hgbot (developer)
2022-05-10 09:45

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e05c5b78c13021016e479ef7318d3d500b0cf026
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 22-04-2022 11:38:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e05c5b78c13021016e479ef7318d3d500b0cf026 [^]

Fixes ISSUE-49111: Discounts tests with node server fail due to usage of not initialized DAL layer

New discounts tests use DAL layer, and as such they require it to be
initialized. Due to previously not requiring it, the dal layer was
closed after the .js was deployed when running the tests in Remote mode
with a node service. Because it is required now to have DAL available,
it is always initialized, which is a little performance hit when running
tests that don't require it.

---
M src-test/org/openbravo/retail/discounts/test/base/DiscountsBaseTest.java
---

- Issue History
Date Modified Username Field Change
2022-04-22 11:25 cberner New Issue
2022-04-22 11:25 cberner Assigned To => Retail
2022-04-22 11:25 cberner OBNetwork customer => No
2022-04-22 11:25 cberner Triggers an Emergency Pack => No
2022-04-22 11:25 cberner Assigned To Retail => cberner
2022-04-22 11:25 cberner Status new => acknowledged
2022-04-22 11:28 hgbot Merge Request Status => open
2022-04-22 11:28 hgbot Note Added: 0136676
2022-04-22 11:40 hgbot Merge Request Status open => approved
2022-05-10 09:45 hgbot Resolution open => fixed
2022-05-10 09:45 hgbot Status acknowledged => closed
2022-05-10 09:45 hgbot Note Added: 0137109
2022-05-10 09:45 hgbot Fixed in Version => RR22Q3
2022-05-10 09:45 hgbot Note Added: 0137110

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker