Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0049051 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | critical | always | 2022-04-12 12:27 | 2022-04-26 14:27 | |||
| Reporter | fermin_ostivar | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | PR22Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR22Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | Gold | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0049051: XML parsers XXE attacks vulnerabilty | |||||||
| Description | We have detected a SaxParser vulnerable to XXE attach in the class TranslationManager final SAXParserFactory factory = SAXParserFactory.newInstance(); final SAXParser parser = factory.newSAXParser(); parser.parse(in, handler); https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_forms/TranslationManager.java#L641 [^] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_forms/TranslationManager.java#L666 [^] | |||||||
| Steps To Reproduce | N/A | |||||||
| Proposed Solution | To create a new get method in the class XMLUtil.java as newSAXReader and to call it in the lines reported previously | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0136725) hgbot (developer) 2022-04-25 17:01 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/567 [^] |
|
(0136757) hgbot (developer) 2022-04-26 14:27 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: ebb6bd67ecc712e0e31fb39243cf935ead8088d0 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 26-04-2022 11:36:15 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ebb6bd67ecc712e0e31fb39243cf935ead8088d0 [^] Fixes ISSUE-49051: Provides a safe way to create instances of SAXParser A new method has been created in XMLUtil to create instances of SAXParser that are not vulnerable to XXE attacks --- M src/org/openbravo/dal/xml/XMLUtil.java M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java --- |
|
(0136758) hgbot (developer) 2022-04-26 14:27 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/567 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-04-13 13:24 | AugustoMauch | Type | design defect => backport |
| 2022-04-13 13:24 | AugustoMauch | Target Version | => PR22Q2 |
| 2022-04-25 17:01 | hgbot | Merge Request Status | => open |
| 2022-04-25 17:01 | hgbot | Note Added: 0136725 | |
| 2022-04-26 11:48 | hgbot | Merge Request Status | open => approved |
| 2022-04-26 14:27 | hgbot | Resolution | open => fixed |
| 2022-04-26 14:27 | hgbot | Status | scheduled => closed |
| 2022-04-26 14:27 | hgbot | Fixed in Version | => PR22Q2 |
| 2022-04-26 14:27 | hgbot | Note Added: 0136757 | |
| 2022-04-26 14:27 | hgbot | Note Added: 0136758 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |