Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048950
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2022-03-10 13:242022-04-01 13:28
ReporteraferrazView Statuspublic 
Assigned Togorka_gil 
PrioritynormalResolutionfixedFixed in VersionRR22Q1.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR22Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - QA Approved
Regression date
Regression introduced in releaseRR22Q1
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048950: Many unneded tax rules are loaded in WebPOS making tax engine very slow

DescriptionMany unneded tax rules are loaded in WebPOS making tax engine very slow
Steps To ReproduceCheck in Information tab from Organization window "Vall Blanca Store" belongs to "Spain" country (id="106").

Check WebPOS loads some tax rules defined for a country different than Spain:
>>new Set(OB.Taxes.Pos.ruleImpls.map(rule => rule.country))
Set(4) {null, '106', '100', '102'}

By default, only rules with empty country or Spain country should be loaded in WebPOS.
Rules defined for other countries should be loaded only in case the store allows to have more than one location (0048093).
Proposed SolutionAdd back to TaxRate.java and TaxZone.java the filters removed in https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/612 [^]
Skip these filters (or filter by every store location) just in case the store allows to have more than one location.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0048762 closedgorka_gil Many unneded tax rules are loaded in WebPOS making tax engine very slow 

-  Notes
(0136253)
hgbot (developer)
2022-04-01 12:54

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/758 [^]
(0136255)
hgbot (developer)
2022-04-01 13:13

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/40 [^]
(0136256)
hgbot (developer)
2022-04-01 13:15

 Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/179 [^]
(0136257)
hgbot (developer)
2022-04-01 13:28

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9941fe908a05b84cf37d6ad49481688675944618
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 12:52:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9941fe908a05b84cf37d6ad49481688675944618 [^]

Fixed ISSUE-48950: only avoid filter taxes when we have many locations per store

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136258)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 931837e59439b12e11ca7ddc4b26da98eddcbdc8
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 12:53:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/931837e59439b12e11ca7ddc4b26da98eddcbdc8 [^]

Related to ISSUE-48950: cross store also needs to load all taxes

Since with crosstore the tax from is where the product is located

---
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136259)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 395eb25db3750b84173cd158f76d62b0adfee154
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 12:53:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/395eb25db3750b84173cd158f76d62b0adfee154 [^]

Related to ISSUE-48950: Review: move condition to a function

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136260)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2600edbebd983760f5c6ff8ca28be16759505a86
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 12:53:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2600edbebd983760f5c6ff8ca28be16759505a86 [^]

Related to ISSUE-48950: Review: Fix copyrigth year, name of preference, parameter name

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/master/TaxRate.java
M src/org/openbravo/retail/posterminal/master/TaxZone.java
---
(0136261)
hgbot (developer)
2022-04-01 13:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/758 [^]
(0136262)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 4bfd7b4014b31d7ab324fd0840a7a8bb468b3ba7
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 13:11:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/4bfd7b4014b31d7ab324fd0840a7a8bb468b3ba7 [^]

Related to ISSUE-48950: take into account the preference when loading org locations

---
M src/org/openbravo/retail/sessions/OrganizationLocation.java
---
(0136263)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 1fb8523e2283152ad19ac43c6d3f524cbb91b949
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 13:12:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/1fb8523e2283152ad19ac43c6d3f524cbb91b949 [^]

Related to ISSUE-48950: Review: Fix copyrigth year, name of preference

---
M src/org/openbravo/retail/sessions/OrganizationLocation.java
---
(0136264)
hgbot (developer)
2022-04-01 13:28

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/40 [^]
(0136265)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: c2ca9d955e226055a2f6919caab20c84aaf68a01
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 13:14:55
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/c2ca9d955e226055a2f6919caab20c84aaf68a01 [^]

Related to ISSUE-48950: active OBPOS_organizationWithMultipleLocations pref in OrgLocations test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136266)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 57d6735864f2081a8f21532eb62257ea5ae14220
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 13:15:02
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/57d6735864f2081a8f21532eb62257ea5ae14220 [^]

Related to ISSUE-48950: try another workaround for test OrgLocations

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136267)
hgbot (developer)
2022-04-01 13:28

 Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: d3a87376b068b0776260b1f11cff61fea5b8d388
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 01-04-2022 13:15:08
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/d3a87376b068b0776260b1f11cff61fea5b8d388 [^]

Related to ISSUE-48950: fix copyrigth year

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OrgLocations.java
---
(0136268)
hgbot (developer)
2022-04-01 13:28

 Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/179 [^]

- Issue History
Date Modified Username Field Change
2022-03-31 16:37 gorka_gil Type defect => backport
2022-03-31 16:37 gorka_gil Target Version => RR22Q1.2
2022-04-01 12:54 hgbot Note Added: 0136253
2022-04-01 13:13 hgbot Note Added: 0136255
2022-04-01 13:15 hgbot Note Added: 0136256
2022-04-01 13:28 hgbot Resolution open => fixed
2022-04-01 13:28 hgbot Status scheduled => closed
2022-04-01 13:28 hgbot Fixed in Version => RR22Q1.2
2022-04-01 13:28 hgbot Note Added: 0136257
2022-04-01 13:28 hgbot Note Added: 0136258
2022-04-01 13:28 hgbot Note Added: 0136259
2022-04-01 13:28 hgbot Note Added: 0136260
2022-04-01 13:28 hgbot Note Added: 0136261
2022-04-01 13:28 hgbot Note Added: 0136262
2022-04-01 13:28 hgbot Note Added: 0136263
2022-04-01 13:28 hgbot Note Added: 0136264
2022-04-01 13:28 hgbot Note Added: 0136265
2022-04-01 13:28 hgbot Note Added: 0136266
2022-04-01 13:28 hgbot Note Added: 0136267
2022-04-01 13:28 hgbot Note Added: 0136268

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker