Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048949 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2022-03-31 16:03 | 2022-04-25 07:52 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR22Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048949: Remove feature to receive alerts from butler via heartbeat reply (i.e. about updates) | |||||||
| Description | The heartbeat sending mechanism has a feature where the server (butler) can send back alert which are shown to the system-administrator role. That feature was designed in 2008 to allow to push back alert about new software version (i.e. Openbravo verion or stack components (i.e. ant,java,database) via the alert system. That was never really used since then and does not fit into current Openbravo usage with bigger installations. Remove the feature as obsolete. | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Remote the client side of this feature (this issue). In parallel server side code in butler codecase is planned to be removed as well. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0136217) shuehner (administrator) 2022-03-31 16:04 |
Old issue 12506 (int -> String uuid bug) can be close as obsolete when this change is done (as it will remove the Alert class 12506 is about) |
|
(0136220) hgbot (developer) 2022-03-31 16:10 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/550 [^] |
|
(0136704) hgbot (developer) 2022-04-25 07:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 2729a85f948c497a981d382dd4ac53ffd595f4cc Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 25-04-2022 05:51:19 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2729a85f948c497a981d382dd4ac53ffd595f4cc [^] Fixes ISSUE-48949: Remove receiving alerts via heartbeat reply. Heartbeat could optionally receive Alerts to show locally via the HB reply from butler. That mechanism was never really used so remove it as obsolete. - Remove supporting code from HeartbeatProcess - Remove Alertrule for it from ADRD dataset - Remove postscript-* code to add SystemAdmin role to above ADRD entry - Very fix-up code from before we had modulescripts for such changes - Remove Alert.java & Alert_data.xsql which were only used for this feature. Especially Alert.java class was not generally useful as still assumed primary key values to be an int (instead of UUID's) --- M src-db/database/model/postscript-Oracle.sql M src-db/database/model/postscript-PostgreSql.sql M src-db/database/sourcedata/AD_MESSAGE.xml M src-db/database/sourcedata/referencedData/AD_ALERTRULE.xml M src-test/src/org/openbravo/test/role/inheritance/HorizontalInheritance.java M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java R src/org/openbravo/erpCommon/utility/Alert.java R src/org/openbravo/erpCommon/utility/Alert_data.xsql --- |
|
(0136705) hgbot (developer) 2022-04-25 07:52 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/550 [^] |
|
(0136706) hgbot (developer) 2022-04-25 07:52 |
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^] Changeset: cf48d38b51f07309a62fe21f233418ef6fcad4fa Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 25-04-2022 07:48:57 URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/cf48d38b51f07309a62fe21f233418ef6fcad4fa [^] fixed ISSUE-49116: API change: removed heartbeat alerts API removals caused by ISSUE-48949: * class org.openbravo.erpCommon.utility.Alert * message HB_UPDATES --- M java/reference/java.japi.gz M model/src-db/database/sourcedata/AD_MESSAGE.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-03-31 16:03 | shuehner | New Issue | |
| 2022-03-31 16:03 | shuehner | Assigned To | => Triage Platform Base |
| 2022-03-31 16:03 | shuehner | Modules | => Core |
| 2022-03-31 16:03 | shuehner | Triggers an Emergency Pack | => No |
| 2022-03-31 16:04 | shuehner | Relationship added | related to 0012506 |
| 2022-03-31 16:04 | shuehner | Note Added: 0136217 | |
| 2022-03-31 16:10 | hgbot | Note Added: 0136220 | |
| 2022-03-31 17:25 | shuehner | Summary | Remove feature to receive alerts from butler via heartbeast reply (i.e. about updates) => Remove feature to receive alerts from butler via heartbeat reply (i.e. about updates) |
| 2022-04-25 07:40 | alostale | Relationship added | depends on 0049116 |
| 2022-04-25 07:51 | alostale | Assigned To | Triage Platform Base => shuehner |
| 2022-04-25 07:52 | hgbot | Resolution | open => fixed |
| 2022-04-25 07:52 | hgbot | Status | new => closed |
| 2022-04-25 07:52 | hgbot | Fixed in Version | => PR22Q3 |
| 2022-04-25 07:52 | hgbot | Note Added: 0136704 | |
| 2022-04-25 07:52 | hgbot | Note Added: 0136705 | |
| 2022-04-25 07:52 | hgbot | Note Added: 0136706 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |