Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048949Openbravo ERPA. Platformpublic2022-03-31 16:032022-04-25 07:52
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048949: Remove feature to receive alerts from butler via heartbeat reply (i.e. about updates)
DescriptionThe heartbeat sending mechanism has a feature where the server (butler) can send back alert which are shown to the system-administrator role.

That feature was designed in 2008 to allow to push back alert about new software version (i.e. Openbravo verion or stack components (i.e. ant,java,database) via the alert system.

That was never really used since then and does not fit into current Openbravo usage with bigger installations.

Remove the feature as obsolete.
Steps To Reproduce-
Proposed SolutionRemote the client side of this feature (this issue).
In parallel server side code in butler codecase is planned to be removed as well.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0012506 acknowledged Triage Platform Base The Alert class for creating alert instances is broken 
depends on defect 0049116 closed alostale API change: removed heartbeat alerts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-03-31 16:03shuehnerNew Issue
2022-03-31 16:03shuehnerAssigned To => Triage Platform Base
2022-03-31 16:03shuehnerModules => Core
2022-03-31 16:03shuehnerTriggers an Emergency Pack => No
2022-03-31 16:04shuehnerRelationship addedrelated to 0012506
2022-03-31 16:04shuehnerNote Added: 0136217
2022-03-31 16:10hgbotNote Added: 0136220
2022-03-31 17:25shuehnerSummaryRemove feature to receive alerts from butler via heartbeast reply (i.e. about updates) => Remove feature to receive alerts from butler via heartbeat reply (i.e. about updates)
2022-04-25 07:40alostaleRelationship addeddepends on 0049116
2022-04-25 07:51alostaleAssigned ToTriage Platform Base => shuehner
2022-04-25 07:52hgbotResolutionopen => fixed
2022-04-25 07:52hgbotStatusnew => closed
2022-04-25 07:52hgbotFixed in Version => PR22Q3
2022-04-25 07:52hgbotNote Added: 0136704
2022-04-25 07:52hgbotNote Added: 0136705
2022-04-25 07:52hgbotNote Added: 0136706

Notes
(0136217)
shuehner   
2022-03-31 16:04   
Old issue 12506 (int -> String uuid bug) can be close as obsolete when this change is done (as it will remove the Alert class 12506 is about)
(0136220)
hgbot   
2022-03-31 16:10   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/550 [^]
(0136704)
hgbot   
2022-04-25 07:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2729a85f948c497a981d382dd4ac53ffd595f4cc
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 25-04-2022 05:51:19
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2729a85f948c497a981d382dd4ac53ffd595f4cc [^]

Fixes ISSUE-48949: Remove receiving alerts via heartbeat reply.

Heartbeat could optionally receive Alerts to show locally via the HB
reply from butler.
That mechanism was never really used so remove it as obsolete.

- Remove supporting code from HeartbeatProcess
- Remove Alertrule for it from ADRD dataset
- Remove postscript-* code to add SystemAdmin role to above ADRD entry
  - Very fix-up code from before we had modulescripts for such changes
- Remove Alert.java & Alert_data.xsql which were only used for this
  feature. Especially Alert.java class was not generally useful as still
  assumed primary key values to be an int (instead of UUID's)

---
M src-db/database/model/postscript-Oracle.sql
M src-db/database/model/postscript-PostgreSql.sql
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/referencedData/AD_ALERTRULE.xml
M src-test/src/org/openbravo/test/role/inheritance/HorizontalInheritance.java
M src/org/openbravo/erpCommon/ad_process/HeartbeatProcess.java
R src/org/openbravo/erpCommon/utility/Alert.java
R src/org/openbravo/erpCommon/utility/Alert_data.xsql
---
(0136705)
hgbot   
2022-04-25 07:52   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/550 [^]
(0136706)
hgbot   
2022-04-25 07:52   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: cf48d38b51f07309a62fe21f233418ef6fcad4fa
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 25-04-2022 07:48:57
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/cf48d38b51f07309a62fe21f233418ef6fcad4fa [^]

fixed ISSUE-49116: API change: removed heartbeat alerts

API removals caused by ISSUE-48949:
  * class org.openbravo.erpCommon.utility.Alert
  * message HB_UPDATES

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MESSAGE.xml
---