Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048855
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. OthersmajorN/A2022-03-21 14:082022-07-07 09:31
ReporterdromeroView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionPR22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocberner
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048855: Openbravo logout with AuthenticationManager implementation

DescriptionAfter speaking with Asier Lostalé, he thought it was appropriate to report the following issue, which was reported in Zendesk by the Partner I quote:

"We have implemented AuthenticationManager to use openam and everything works correctly.
At the time of logout we want to leave openbravo but not openam, for this we are trying to redirect to a new url, but it does not work, redirects to openbravo login always.

This is the code we put:
@Override
protected void doLogout(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {

response.sendRedirect("www.example.com");

}"
Steps To ReproduceN/A
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0136322)
dromero (reporter)
2022-04-04 18:57

Hello, any news on this matter? I note that the status of the issue remains the same since it was reported.

Regards,
Demián
(0136476)
dromero (reporter)
2022-04-11 18:43

Hello, we are on the issue due date. Haven't you had time to review it? Do you need me to extend the due date for the issue to be addressed?

Regards,
Demián
(0136595)
hgbot (developer)
2022-04-19 13:49

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/563 [^]
(0136599)
ivancaceres (reporter)
2022-04-19 15:21

Hi Augusto,

I have tried the solution but it doesn't seem to work with AuthenticationManager implementation.

Thanks
(0136630)
AugustoMauch (manager)
2022-04-20 13:53

Hello Ivan,

Thanks for testing it. Can you explain how could I test it with the AUthenticationManager implementation? If you cannot attach it to this issue you can share it with me at augusto.mauch@openbravo.com
(0136643)
ivancaceres (reporter)
2022-04-20 15:00

Hi Augusto,

Yo can try with AutologonAuthenticationManager.
(0136652)
AugustoMauch (manager)
2022-04-20 17:56

I just tested it and it worked fine, I was properly redirected. See attached video:
- I opened an incognito window to ensure a clean session
- Opened openbravo, was logged in automatically
- On logout I was properly redirected

Openbravo.properties modified configuration:
authentication.class=org.openbravo.authentication.basic.AutologonAuthenticationManager
authentication.autologon.username=Openbravo
logout.redirect=https://www.google.com [^]
(0136686)
ivancaceres (reporter)
2022-04-22 14:14

Hola Augusto,

Lo he probado con nuestro módulo que implementa OpenAM y he conseguido que funcione.

He tenido que copiar el método doLogout() de la clase AutologonAuthenticationManager

  @Override
  protected void doLogout(HttpServletRequest request, HttpServletResponse response)
      throws ServletException, IOException {
    response.sendRedirect(HttpBaseUtils.getLocalAddress(request));
  }

Un saludo y gracias por el parche
(0136730)
hgbot (developer)
2022-04-25 18:26

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/563 [^]
(0136731)
hgbot (developer)
2022-04-25 18:26

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c9bfab20ee62f3e1fc2b8a6f71a1c3af8cc365a3
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 25-04-2022 17:57:31
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c9bfab20ee62f3e1fc2b8a6f71a1c3af8cc365a3 [^]

Fixes ISSUE-48855: Custom logout redirects can be defined

By default when logging out the user is redirected to the Openbravo login page. Now it is possible to define custom redirect urls by setting the Logout Redirect URL (LogoutRedirectURL search key) preference:
- as system admin
- with all Visible At fields empty

Value example: https://www.google.com [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/ApplicationComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
M src-db/database/sourcedata/AD_REF_LIST.xml
---

- Issue History
Date Modified Username Field Change
2022-03-21 14:08 dromero New Issue
2022-03-21 14:08 dromero Assigned To => Triage Omni OMS
2022-03-21 14:08 dromero Modules => Core
2022-03-21 14:08 dromero Triggers an Emergency Pack => No
2022-03-21 15:40 aferraz Assigned To Triage Omni OMS => Triage Platform Base
2022-03-22 07:30 ivancaceres Issue Monitored: ivancaceres
2022-04-04 18:57 dromero Note Added: 0136322
2022-04-11 18:43 dromero Note Added: 0136476
2022-04-19 13:40 AugustoMauch Assigned To Triage Platform Base => AugustoMauch
2022-04-19 13:40 AugustoMauch Status new => scheduled
2022-04-19 13:49 hgbot Note Added: 0136595
2022-04-19 15:21 ivancaceres Note Added: 0136599
2022-04-20 13:19 AugustoMauch Review Assigned To => cberner
2022-04-20 13:53 AugustoMauch Note Added: 0136630
2022-04-20 15:00 ivancaceres Note Added: 0136643
2022-04-20 17:56 AugustoMauch Note Added: 0136652
2022-04-22 14:14 ivancaceres Note Added: 0136686
2022-04-25 18:26 hgbot Resolution open => fixed
2022-04-25 18:26 hgbot Status scheduled => closed
2022-04-25 18:26 hgbot Note Added: 0136730
2022-04-25 18:26 hgbot Fixed in Version => PR22Q3
2022-04-25 18:26 hgbot Note Added: 0136731
2022-07-07 09:31 plujan Description Updated View Revisions


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker