Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0048701

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2022-03-01 14:22

2022-03-03 08:18

Reporter

malsasua

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR22Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0048701: Payment data is retrieved as a String instead of json

Description

When reprint functionality is used, the receipt loaded from the backoffice is loaded with the paymentData property as string, instead of Json

Steps To Reproduce

. in live:
1. load POS
2. select Arturo Montoro
3. Menu > issue invoice
4. add line
5. click in total button
6. add payment
7. in Chrome Dev Tools execute:
OB.MobileApp.model.receipt.get('payments').at(0).set('paymentData', {"a":1});
OB.MobileApp.model.receipt.save()
8. complete the ticket
9. Open receipt > load previous receipt
10. in Chrome Dev Tools:
add breakpoint in line 111514 (see screenshot)
11. Menu > print: select invoice and click in "invoice" button
the execution is stopped in breakpont
check the value of
data.at(0).receiptPayments.at(0).paymentData
it is one string instead of json
(see screenshot 2)

Tags

No tags attached.

1.png [^] (41,491 bytes) 2022-03-01 14:23

2.png [^] (48,444 bytes) 2022-03-01 14:23

48701_19Q3_posterminal.diff [^] (1,583 bytes) 2022-03-03 05:45 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/Invoices.java b/src/org/openbravo/retail/posterminal/Invoices.java
index b610050f7..210abd0a6 100644
--- a/src/org/openbravo/retail/posterminal/Invoices.java
+++ b/src/org/openbravo/retail/posterminal/Invoices.java
@@ -230,7 +230,8 @@ public class Invoices extends JSONProcessSimple {
                       .multiply(new BigDecimal((String) objectType.get("mulrate").toString())));
               invoicePayment.put("paymentDate", objectIn.get("paymentDate"));
               if (objectIn.has("paymentData")) {
-                invoicePayment.put("paymentData", objectIn.get("paymentData"));
+                invoicePayment.put("paymentData",
+                    new JSONObject((String) objectIn.get("paymentData")));
               }
               invoicePayment.put("name", objectType.get("name"));
               invoicePayment.put("kind", objectType.get("kind"));
@@ -274,7 +275,8 @@ public class Invoices extends JSONProcessSimple {
                       .multiply(new BigDecimal((String) paymentsType.get("mulrate").toString())));
               invoicePayment.put("paymentDate", objectIn.get("paymentDate"));
               if (objectIn.has("paymentData")) {
-                invoicePayment.put("paymentData", objectIn.get("paymentData"));
+                invoicePayment.put("paymentData",
+                    new JSONObject((String) objectIn.get("paymentData")));
               }
               invoicePayment.put("name", paymentsType.get("name"));
               invoicePayment.put("kind", paymentsType.get("kind"));

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0135367) malsasua (developer) 2022-03-01 17:37	This problem is reported by a customer in 19Q3. A backport is required

(0135391) hgbot (developer) 2022-03-02 15:25	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/732 [^]

(0135411) hgbot (developer) 2022-03-03 08:18	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/732 [^]

(0135412) hgbot (developer) 2022-03-03 08:18	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 7b5494f4d51fb91a8bbde9df8ff342741d96d9df Author: Ranjith S R <ranjith@qualiantech.com> Date: 02-03-2022 14:32:11 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7b5494f4d51fb91a8bbde9df8ff342741d96d9df [^] Fixed ISSUE-48701: PaymentData converted to json when loading invoices --- M src/org/openbravo/retail/posterminal/Invoices.java ---

Issue History
Date Modified	Username	Field	Change
2022-03-01 14:22	malsasua	New Issue
2022-03-01 14:22	malsasua	Assigned To	=> Retail
2022-03-01 14:22	malsasua	Triggers an Emergency Pack	=> No
2022-03-01 14:23	malsasua	File Added: 1.png
2022-03-01 14:23	malsasua	File Added: 2.png
2022-03-01 17:37	malsasua	Note Added: 0135367
2022-03-02 08:03	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2022-03-02 08:35	ranjith_qualiantech_com	Status	new => scheduled
2022-03-02 15:25	hgbot	Note Added: 0135391
2022-03-03 05:45	ranjith_qualiantech_com	File Added: 48701_19Q3_posterminal.diff
2022-03-03 08:18	hgbot	Note Added: 0135411
2022-03-03 08:18	hgbot	Resolution	open => fixed
2022-03-03 08:18	hgbot	Status	scheduled => closed
2022-03-03 08:18	hgbot	Fixed in Version	=> RR22Q2
2022-03-03 08:18	hgbot	Note Added: 0135412

Copyright © 2000 - 2009 MantisBT Group