0048527: Log message level is too high

Description

In the DefaultDataSourceService class, a message is written on the log when building the database properties of generated windows if for some reason DalUtil.getPropertyFromPath(entity, additionalProp) returns false, meaning that there is no property in the given entity with the given name.

This happens some times when using selectors that have fields with aliases. The log is not very useful because there aren't any side effects when the property is not found. We could either change the log devel to debug or remove, I prefer to keep the log with debug level.

Steps To Reproduce

- Log in in the backoffice
- Open the Sales Invoice window. Notice that the following message is logged:

2022-02-03 14:07:05,590 [http-nio-8080-exec-10] INFO org.openbravo.service.datasource.DefaultDataSourceService - Couldn't find property from additional property product$productName in entity InvoiceLine

Tags

No tags attached.

Attached Files

48527.diff [^] (1,444 bytes) 2022-02-15 06:52 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
index ed52bbcfcf..a75af34ded 100644
--- a/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
+++ b/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2010-2016 Openbravo SLU
+ * All portions are Copyright (C) 2010-2022 Openbravo SLU
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -398,7 +398,7 @@ public class DefaultDataSourceService extends BaseDataSourceService {
       for (String additionalProp : additionalProps) {
         final Property property = DalUtil.getPropertyFromPath(entity, additionalProp);
         if (property == null) {
-          log4j.info("Couldn't find property from additional property " + additionalProp
+          log4j.debug("Couldn't find property from additional property " + additionalProp
               + " in entity " + entity);
           continue;
         }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0135143) hgbot (developer) 2022-02-19 12:01	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/529 [^]

(0135144) hgbot (developer) 2022-02-19 12:02	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/529 [^]

(0135145) hgbot (developer) 2022-02-19 12:02	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: dd2f67a4de1a5a1bef4942415f92140590a53051 Author: adrian.blasco <adrian.blasco@openbravo.com> Date: 19-02-2022 12:01:57 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/dd2f67a4de1a5a1bef4942415f92140590a53051 [^] fixes ISSUE-48527: Log message level is too high --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java ---

Issue History
Date Modified	Username	Field	Change
2022-02-03 14:08	AugustoMauch	New Issue
2022-02-03 14:08	AugustoMauch	Assigned To	=> Triage Platform Base
2022-02-03 14:08	AugustoMauch	OBNetwork customer	=> No
2022-02-03 14:08	AugustoMauch	Modules	=> Core
2022-02-03 14:08	AugustoMauch	Triggers an Emergency Pack	=> No
2022-02-03 14:08	AugustoMauch	Summary	Log message is => Log message level is too high
2022-02-15 06:52	guillermogil	File Added: 48527.diff
2022-02-19 12:01	hgbot	Merge Request Status	=> open
2022-02-19 12:01	hgbot	Note Added: 0135143
2022-02-19 12:02	hgbot	Merge Request Status	open => approved
2022-02-19 12:02	hgbot	Resolution	open => fixed
2022-02-19 12:02	hgbot	Status	new => closed
2022-02-19 12:02	hgbot	Note Added: 0135144
2022-02-19 12:02	hgbot	Fixed in Version	=> PR22Q2
2022-02-19 12:02	hgbot	Note Added: 0135145
2022-02-19 12:02	AugustoMauch	Assigned To	Triage Platform Base => ablasco