Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0048440

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Localization Pack: Spain] SII

major

have not tried

2022-01-19 17:31

2022-04-01 10:51

Reporter

vmromanos

View Status

public

Assigned To

vmromanos

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

No

Regression introduced in release

Summary

0048440: SendInvoicesGroupsToAEAT might have problems when sending many invoices

Description

The SendInvoicesGroupsToAEAT class might have the following issues:

1. It loads into memory many DAL objects without flushing and clearing cache on a regular basis. This might create an out of memory exception if the number of invoices to load is too high.

2. If the number of invoices to send in the batch, we might exceed a limit in the AEAT side (to be confirmed if this limit exists and the exact number).

Steps To Reproduce

Detected in code review.

Proposed Solution

1. Flush and clear session while iterating over the invoices.

2. Add a limit to the invoices retrieved by the main query.

Tags

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

design defect

new

SII performance review

Notes
(0135823) hgbot (developer) 2022-03-17 20:37	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/32 [^]

(0136140) hgbot (developer) 2022-03-29 18:57	Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/32 [^]

(0136141) hgbot (developer) 2022-03-29 19:08	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/34 [^]

(0136246) hgbot (developer) 2022-04-01 10:51	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii [^] Changeset: 1946238ec4e58fe725343704313171023537570b Author: Roberto Carlos Toledano Gómez <rctg82@gmail.com> Date: 01-04-2022 08:51:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/commit/1946238ec4e58fe725343704313171023537570b [^] Fixed ISSUE-48440: Fixed Performances issues related with hibernate cache management. --- A src-db/database/sourcedata/AD_PREFERENCE.xml M src-db/database/sourcedata/AD_MODULE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M src/org/openbravo/module/sii/process/background/SendInvoicesGroupsToAEAT.java M src/org/openbravo/module/sii/utils/SIIUtils.java ---

(0136247) hgbot (developer) 2022-04-01 10:51	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/34 [^]

Issue History
Date Modified	Username	Field	Change
2022-01-19 17:31	vmromanos	New Issue
2022-01-19 17:31	vmromanos	Assigned To	=> Jorge Bravo
2022-01-19 17:31	vmromanos	OBNetwork customer	=> No
2022-01-19 17:31	vmromanos	Assigned To	Jorge Bravo => vmromanos
2022-02-21 16:19	rafaroda	Relationship added	related to 0048238
2022-02-21 16:19	rafaroda	Tag Attached: NOR
2022-03-17 20:37	hgbot	Merge Request Status	=> open
2022-03-17 20:37	hgbot	Note Added: 0135823
2022-03-29 18:57	hgbot	Note Added: 0136140
2022-03-29 19:08	hgbot	Note Added: 0136141
2022-04-01 10:51	hgbot	Merge Request Status	open => approved
2022-04-01 10:51	hgbot	Resolution	open => fixed
2022-04-01 10:51	hgbot	Status	new => closed
2022-04-01 10:51	hgbot	Note Added: 0136246
2022-04-01 10:51	hgbot	Note Added: 0136247

Copyright © 2000 - 2009 MantisBT Group