Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048361
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2022-01-07 10:452022-01-12 17:59
ReporterjavietxeView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR22Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048361: "fin_trans_amounts_chk" Error in errors while importing while doing a cashup

DescriptionWhen creating a cashup, a check is done to know if a transaction has to be created or not.

If the transaction is 0, some times it still created. In this case, the cashup stays in errors while importing with the error:

new row for relation "fin_finacc_transaction" violates check constraint "fin_trans_amounts_chk"
Steps To ReproduceConfigure the credit notes to use in the till.

Do a cashup and close the till.

Open the till.

Create a credit card by the till.

Use the the whole value of the credit card to pay an order.

Do a cashup.

Check that the cashup is in the errors while importing.
Proposed SolutionChange the amount comparison:
if (amount == BigDecimal.ZERO) {


Substitute it by
if (amount.compareTo(BigDecimal.ZERO) == 0) {
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0134149)
hgbot (developer)
2022-01-07 10:50

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/681 [^]
(0134278)
hgbot (developer)
2022-01-12 17:59

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8e5ec7ec48ba81cfe934d44d83352c1e5bde8697
Author: Jorge Garcia <jorge.garcia@openbravo.com>
Date: 12-01-2022 16:58:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8e5ec7ec48ba81cfe934d44d83352c1e5bde8697 [^]

Fixed ISSUE-48361: Use compareTo method in safe boxes to avoid
generation 0 value transactions

---
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---
(0134279)
hgbot (developer)
2022-01-12 17:59

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/681 [^]

- Issue History
Date Modified Username Field Change
2022-01-07 10:45 javietxe New Issue
2022-01-07 10:45 javietxe Assigned To => Retail
2022-01-07 10:45 javietxe Triggers an Emergency Pack => No
2022-01-07 10:50 hgbot Note Added: 0134149
2022-01-07 10:54 javietxe Summary Error comparing bigdecimals => "fin_trans_amounts_chk" Error in errors while importing while doing a cashup
2022-01-07 10:54 javietxe Description Updated View Revisions
2022-01-07 10:54 javietxe Steps to Reproduce Updated View Revisions
2022-01-07 10:54 javietxe Proposed Solution updated
2022-01-07 11:18 jorge-garcia Assigned To Retail => jorge-garcia
2022-01-07 11:19 jorge-garcia Status new => scheduled
2022-01-12 17:59 hgbot Resolution open => fixed
2022-01-12 17:59 hgbot Status scheduled => closed
2022-01-12 17:59 hgbot Fixed in Version => RR22Q2
2022-01-12 17:59 hgbot Note Added: 0134278
2022-01-12 17:59 hgbot Note Added: 0134279


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker