Anonymous | Login
Openbravo.com
Wiki
Code
Forge
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0048069
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts by Totalmajoralways2021-11-16 12:002021-12-23 08:10
ReporterTheo_DelobelView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRR20Q3SCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048069: Discount/promotion type Free Product per Total

DescriptionIn the WebPos, when we try to use promotion type : Free Products per Total Amount
the amount of the free product is add to the total receipt
Steps To Reproducein the window : discount and promotion

set up a promotion as following :
discount/promotion type : Free Products per Total Amount
Included BP Categories: Only those defined
Included BP Set :All excluding defined
Included Business Partners :All excluding defined
Included Product Categories :All excluding defined
Included Products :Only those defined
Include Price Lists :All excluding defined
Included Organizations :All excluding defined
Included Characteristics :All excluding defined

Total receipt :12,000.00

In the tab : Business partner category : Reseller
in the tab product : one productA
In the tab free product : another productB


If you made a sales with productA for 13,000
the free productB is proposed but if you selected it, the amount of the productB is add to the total amount of the receipt.
Proposed Solutionit seems the issue come from getApplicableLines method.

It takes only the lines with the products found in the 'Only one defined' configuration.
TagsNo tags attached.
Attached Files? file icon Discount issue Free Product per Totla Amount-2021-11-15_18.07.15.mkv [^] (2,833,745 bytes) 2021-11-16 12:00

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0048732RR20Q3.3 closedrqueralta Free item is not added with 100% discount at POS 

-  Notes
(0133156)
Theo_Delobel (reporter)
2021-11-17 15:18

 I found that will i made some research :
it goes through the discount engine
which calls the method getApplicableLines
This method returns the lines on which you can apply a promotion,

Except that it returns the ticket without the line with the free object
Then it applies a filter on these lines to remove the price of the free item
(0133268)
Theo_Delobel (reporter)
2021-11-23 08:55

 Hello,

The customer ask me for the delay of resolution for this issue
Can you tell me when it can be solve ?
(0133383)
hgbot (developer)
2021-11-26 06:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/13 [^]
(0133408)
hgbot (developer)
2021-11-30 08:26

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal [^]
Changeset: 1b2a12ddf97ee87db292b2a7709cfc75f478f28e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-11-30T07:26:27+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/commit/1b2a12ddf97ee87db292b2a7709cfc75f478f28e [^]

Fixed ISSUE-48069: FreeProducts should be applied even if discount product is not configured

---
M src-test/org/openbravo/discounts/bytotal/test/unittests/DiscountByTotalFreeItemsTest.java
M web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js
---
(0133409)
hgbot (developer)
2021-11-30 08:26

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/13 [^]
(0133789)
ranjith_qualiantech_com (developer)
2021-12-17 07:45

 Free product discount should be applied for the following case
Type : Free Products per Total Amount
C1 : Minimum ticket amount : 150
C2 : Product Characteristic : Brand = Makita
Free product : Screwdriver set (price 50 €) (Brand : Bosch)

If 3 Screwdriver sets, my ticket is at 150 €, adding a new Screwdriver set will create the Free product discount. But it should not
(0133891)
hgbot (developer)
2021-12-22 06:56

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/16 [^]
(0133920)
hgbot (developer)
2021-12-23 08:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal [^]
Changeset: 7ea42b16bc90ece920c34de974fcc102d9d91572
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-12-2021 13:18:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/commit/7ea42b16bc90ece920c34de974fcc102d9d91572 [^]

Fixed ISSUE-48069: FreeProduct should not be included to reach Discount TotalAmount
* For FreeItem discount, FreeProduct should not be included to calculate
  the discount total amount

---
M src-test/org/openbravo/discounts/bytotal/test/unittests/DiscountByTotalFreeItemsTest.java
M web/org.openbravo.retail.discounts.bytotal/app/model/business-logic/discounts-engine/engine/rules/by-total-free-item-discount.js
---
(0133921)
hgbot (developer)
2021-12-23 08:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/16 [^]

- Issue History
Date Modified Username Field Change
2021-11-16 12:00 Theo_Delobel New Issue
2021-11-16 12:00 Theo_Delobel Assigned To => Retail
2021-11-16 12:00 Theo_Delobel File Added: Discount issue Free Product per Totla Amount-2021-11-15_18.07.15.mkv
2021-11-16 12:00 Theo_Delobel Triggers an Emergency Pack => No
2021-11-17 15:18 Theo_Delobel Note Added: 0133156
2021-11-23 08:55 Theo_Delobel Note Added: 0133268
2021-11-24 07:26 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-11-24 07:43 marvintm Status new => scheduled
2021-11-26 06:32 hgbot Note Added: 0133383
2021-11-30 08:26 hgbot Resolution open => fixed
2021-11-30 08:26 hgbot Status scheduled => closed
2021-11-30 08:26 hgbot Note Added: 0133408
2021-11-30 08:26 hgbot Note Added: 0133409
2021-12-17 07:45 ranjith_qualiantech_com Note Added: 0133789
2021-12-17 07:45 ranjith_qualiantech_com Status closed => new
2021-12-17 07:45 ranjith_qualiantech_com Resolution fixed => open
2021-12-17 07:45 ranjith_qualiantech_com Status new => scheduled
2021-12-22 06:56 hgbot Note Added: 0133891
2021-12-23 08:10 hgbot Resolution open => fixed
2021-12-23 08:10 hgbot Status scheduled => closed
2021-12-23 08:10 hgbot Note Added: 0133920
2021-12-23 08:10 hgbot Note Added: 0133921
2022-03-30 07:35 marvintm Relationship added has duplicate 0048732

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker