Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0048025

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2021-11-10 09:55

2022-01-19 13:27

Reporter

shuehner

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR22Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0048025: Remove obsolete usage of MultiServerJSONProcess (storeserver) from posterminal module

Description

The IsOrderCancelled class extends the MultiServerJSONProcess which is part of the obsolete storeserver project.

Any use of it should be removed.

Steps To Reproduce

grep -r MultiServerJSONProcess

Proposed Solution

Probably
- Extend JSONProcessSimple instead
- Adjust
    protected JSONObject execute(JSONObject json) {
  to be
    public JSONObject exec(JSONObject json) {
- protected void createArchiveEntry
  Remove and replace by equivalent in the matching ImportEntryProcessor

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0048024		closed	rqueralta	Remove obsolete usage of MultiServerJSONProcess (storeserver) from giftcards module
related to	defect	0048429		closed	Retail	API Change: Removed MultiServerJSONProcess usage from retail.posterminal module
blocks	defect	0048220		closed	rqueralta	mobile:core: Delete the MultiServerJSONProcess class which is part of obsolete storeserver code.

Notes
(0134370) hgbot (developer) 2022-01-19 05:41	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/692 [^]

(0134387) hgbot (developer) 2022-01-19 13:27	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/692 [^]

(0134388) hgbot (developer) 2022-01-19 13:27	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 0ecac1c54dcc68620f447c23e13dc65c2c949cca Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 19-01-2022 12:27:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0ecac1c54dcc68620f447c23e13dc65c2c949cca [^] Fixed BUG-48025: Removed obsolete usage of MultiServerJSONProcess --- M src/org/openbravo/retail/posterminal/process/IsOrderCancelled.java ---

Issue History
Date Modified	Username	Field	Change
2021-11-10 09:55	shuehner	New Issue
2021-11-10 09:55	shuehner	Assigned To	=> Retail
2021-11-10 09:55	shuehner	OBNetwork customer	=> No
2021-11-10 09:55	shuehner	Triggers an Emergency Pack	=> No
2021-11-10 09:55	shuehner	Issue generated from	0048024
2021-11-10 09:55	shuehner	Relationship added	related to 0048024
2021-11-10 09:55	shuehner	Relationship added	blocks 0048000
2021-12-10 13:36	shuehner	Relationship added	blocks 0048220
2021-12-10 13:37	shuehner	Relationship deleted	blocks 0048000
2021-12-17 00:29	rqueralta	Assigned To	Retail => rqueralta
2021-12-17 00:29	rqueralta	Status	new => scheduled
2022-01-19 05:41	hgbot	Merge Request Status	=> open
2022-01-19 05:41	hgbot	Note Added: 0134370
2022-01-19 13:27	hgbot	Merge Request Status	open => approved
2022-01-19 13:27	hgbot	Resolution	open => fixed
2022-01-19 13:27	hgbot	Status	scheduled => closed
2022-01-19 13:27	hgbot	Note Added: 0134387
2022-01-19 13:27	hgbot	Fixed in Version	=> RR22Q2
2022-01-19 13:27	hgbot	Note Added: 0134388
2022-01-19 14:00	marvintm	Relationship added	related to 0048429

Copyright © 2000 - 2009 MantisBT Group