Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047923
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarymajorhave not tried2021-10-22 13:202021-11-17 00:28
ReporteralostaleView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionfixedFixed in VersionPR22Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047923: broken field layout when different modules add fields to the same tab

DescriptionWhen there are several modules adding fields to the same tab, the field layout can easily get broken.

The main reason is fields only take into account their seqno value to get sorted.

Given a tab with the following fields and field groups:

Steps To Reproduce
seqNo | Fld | FldGrp
------+-----+--------
  100 | a   | A
  110 | b   | (null)  
  120 | c   | B
  130 | d   | A 
  140 | e   | (null)


The tab would be rendered as:

A ----------
a  
b

B ----------
c

A ----------
d
e
Proposed SolutionPrevent splitting a field group in different pieces.

The previous case should be rendered as:

A ----------
a
b
d

B ----------
c
e



To achieve this, change the algorithm to sort fields to:

1. Sort fields by seqNo until the next field group
2. Within a field group sort by seqNo
3. Fields without a field group are considered part of the current field group
4. When there is a field with a different field group: look for other fields with the current field group with a higher sequence, add them before the new field group
5. Add the field with the new field group
6. Repeat from step 1 till there are no more fields in the tab

TagsNo tags attached.
Attached Filespng file icon multi-fld-grp.png [^] (60,941 bytes) 2021-10-25 10:10

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0132931)
hgbot (developer)
2021-11-10 12:49

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/453 [^]
(0133127)
hgbot (developer)
2021-11-17 00:28

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/453 [^]
(0133128)
hgbot (developer)
2021-11-17 00:28

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9ff649f03998a3b74f794e673ae8bfa4404d3254
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 2021-11-17T00:27:27+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9ff649f03998a3b74f794e673ae8bfa4404d3254 [^]

Fixes ISSUE-47923: Fieldgroup split prevention in backoffice view generation

---
A modules/org.openbravo.client.application/src-test/org/openbravo/client/application/window/OBViewFieldHandlerFieldSorterTest.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
M src-test/src/org/openbravo/test/StandaloneTestSuite.java
---

- Issue History
Date Modified Username Field Change
2021-10-22 13:20 alostale New Issue
2021-10-22 13:20 alostale Assigned To => platform
2021-10-22 13:20 alostale OBNetwork customer => No
2021-10-22 13:20 alostale Modules => Core
2021-10-22 13:20 alostale Triggers an Emergency Pack => No
2021-10-22 13:26 alostale Proposed Solution updated
2021-10-22 13:27 alostale Proposed Solution updated
2021-10-22 13:28 alostale OBNetwork customer No => Gold
2021-10-25 10:10 alostale File Added: multi-fld-grp.png
2021-10-26 12:06 AugustoMauch Status new => acknowledged
2021-10-26 12:06 AugustoMauch Assigned To platform => ablasco
2021-10-26 12:06 AugustoMauch Status acknowledged => scheduled
2021-11-10 12:49 hgbot Merge Request Status => open
2021-11-10 12:49 hgbot Note Added: 0132931
2021-11-17 00:26 hgbot Merge Request Status open => approved
2021-11-17 00:28 hgbot Resolution open => fixed
2021-11-17 00:28 hgbot Status scheduled => closed
2021-11-17 00:28 hgbot Note Added: 0133127
2021-11-17 00:28 hgbot Fixed in Version => PR22Q1
2021-11-17 00:28 hgbot Note Added: 0133128

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker