0047842: Promotion Behaviour - Discounts applied if product has any one of the defined characteristics for ALL EXCLUDING DEFINED.

Description

Discounts and promotions is applied if product has any one of the defined characteristics for ALL EXCLUDING DEFINED in included characteristics.
The solution is Promotions should not be applied when product has any one of the defined characteristics in ALL EXCLUDING DEFINED characteristics.

Steps To Reproduce

In Back office,
1) Create new discounts and promotions and define ALL EXCLUDING CHARACTERISTICS in Included characteristics.
2) Add two characteristics in characteristics tab.
In POS,
1) Add product with any one of the defined characteristics - Promotion is applied.
2) Add product with all the defined characteristics - Promotion is not applied.

Proposed Solution

In Back office
1) Create new discounts and promotions and define ALL EXCLUDING CHARACTERISTICS in Included characteristics.
2) Add two characteristics in characteristics tab.
In POS,
1) Add product with any one of the defined characteristics - Promotion should not be applied.
2) Add product with all the defined characteristics - Promotion is not applied.

Tags

No tags attached.

Attached Files

Ticket26449_patch.diff [^] (765 bytes) 2021-10-13 15:31 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js b/web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
index b653fb2..019dc8b 100644
--- a/web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
+++ b/web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js
@@ -192,7 +192,7 @@
         });
         applicable =
           (rule.includedCharacteristics === 'N' && lineCount > 0) ||
-          (rule.includedCharacteristics === 'Y' && !elementFound) ||
+          (rule.includedCharacteristics === 'Y' && lineCount === 0) ||
           (rule.includedCharacteristics === 'A' &&
             lineCount === rule.productCharacteristics.length);
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0132374) marvintm (manager) 2021-10-18 07:55	This issue is actually not valid, for the current release. Since 20Q3, we have the ability to separately filter by included and excluded characteristics: http://wiki.openbravo.com/wiki/Retail:Discounts_and_Promotions_Rules#Discounts_which_include_or_exclude_certain_characteristic_values [^] This is the proper way to implement this behaviour.

Issue History
Date Modified	Username	Field	Change
2021-10-13 15:31	swathi_kamal	New Issue
2021-10-13 15:31	swathi_kamal	Assigned To	=> Retail
2021-10-13 15:31	swathi_kamal	File Added: Ticket26449_patch.diff
2021-10-13 15:31	swathi_kamal	Triggers an Emergency Pack	=> No
2021-10-18 07:43	swathi_kamal	Priority	normal => high
2021-10-18 07:55	marvintm	Review Assigned To	=> marvintm
2021-10-18 07:55	marvintm	Note Added: 0132374
2021-10-18 07:55	marvintm	Status	new => closed
2021-10-18 07:55	marvintm	Resolution	open => no change required
2021-10-18 07:55	marvintm	Fixed in Version	=> RR20Q3