Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0047677
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2021-09-13 12:322021-09-15 18:52
ReporterAtulOpenbravoView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047677: Close button in Gift Card Dialog Form does not close the dialog

DescriptionWhen user inputs a valid document number for selecting gift card in the dialog, Gift Card details gets loaded in form, however if use tries to close the dialog using close button, it does not get closed.
Steps To Reproduce-Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS. Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment, or just generating a credit note from a returned order by using this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/73 [^] [^]
- Create a ticket. Add products, Select to pay it with credit note. Input the document number of the credit note in the selector.
- Try to close the Dialog, realize that it does not get closed
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0047226 closedAtulOpenbravo Credit notes generated when "Credit note expiration days" is set to 0 cannot be used 

-  Notes
(0131754)
AtulOpenbravo (developer)
2021-09-14 07:16

Test Plan
- Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS. Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment, or just generating a credit note from a returned order by using this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/73 [^] [^] [^]
- Create a ticket. Add products, Select to pay it with credit note. Input the document number of the credit note in the selector.
- Try to close the Dialog, realize that it gets closed.
(0131755)
hgbot (developer)
2021-09-14 07:20

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/86 [^]
(0131836)
hgbot (developer)
2021-09-15 18:52

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 1c11037ef54a70c437bc1ce5cb5130f67bbcf55a
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-09-15T16:42:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/1c11037ef54a70c437bc1ce5cb5130f67bbcf55a [^]

Fixes BUG-0047677: Close button in Gift Card Dialog Form does
not close the dialog

**Add options validForm with value false for close action as
expiration date for gift card is blank in case expiration days
is set as 0 in the organization.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
---
(0131837)
hgbot (developer)
2021-09-15 18:52

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/86 [^]

- Issue History
Date Modified Username Field Change
2021-09-13 12:32 AtulOpenbravo New Issue
2021-09-13 12:32 AtulOpenbravo Assigned To => Retail
2021-09-13 12:32 AtulOpenbravo Triggers an Emergency Pack => No
2021-09-13 12:33 AtulOpenbravo Assigned To Retail => AtulOpenbravo
2021-09-13 12:33 AtulOpenbravo Relationship added related to 0047226
2021-09-14 07:16 AtulOpenbravo Status new => scheduled
2021-09-14 07:16 AtulOpenbravo Note Added: 0131754
2021-09-14 07:20 hgbot Note Added: 0131755
2021-09-15 18:52 hgbot Resolution open => fixed
2021-09-15 18:52 hgbot Status scheduled => closed
2021-09-15 18:52 hgbot Note Added: 0131836
2021-09-15 18:52 hgbot Note Added: 0131837


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker