Openbravo Issue Tracking System - POS2
View Issue Details
0047677POS2POSpublic2021-09-13 12:322021-09-15 18:52
AtulOpenbravo 
AtulOpenbravo 
normalminorhave not tried
closedfixed 
5
 
 
No
0047677: Close button in Gift Card Dialog Form does not close the dialog
When user inputs a valid document number for selecting gift card in the dialog, Gift Card details gets loaded in form, however if use tries to close the dialog using close button, it does not get closed.
-Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS. Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment, or just generating a credit note from a returned order by using this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/73 [^] [^]
- Create a ticket. Add products, Select to pay it with credit note. Input the document number of the credit note in the selector.
- Try to close the Dialog, realize that it does not get closed
No tags attached.
related to defect 0047226 closed AtulOpenbravo Credit notes generated when "Credit note expiration days" is set to 0 cannot be used 
Issue History
2021-09-13 12:32AtulOpenbravoNew Issue
2021-09-13 12:32AtulOpenbravoAssigned To => Retail
2021-09-13 12:32AtulOpenbravoTriggers an Emergency Pack => No
2021-09-13 12:33AtulOpenbravoAssigned ToRetail => AtulOpenbravo
2021-09-13 12:33AtulOpenbravoRelationship addedrelated to 0047226
2021-09-14 07:16AtulOpenbravoStatusnew => scheduled
2021-09-14 07:16AtulOpenbravoNote Added: 0131754
2021-09-14 07:20hgbotNote Added: 0131755
2021-09-15 18:52hgbotResolutionopen => fixed
2021-09-15 18:52hgbotStatusscheduled => closed
2021-09-15 18:52hgbotNote Added: 0131836
2021-09-15 18:52hgbotNote Added: 0131837

Notes
(0131754)
AtulOpenbravo   
2021-09-14 07:16   
Test Plan
- Configure "Credit notes expiration days" to 0 in Organization window.
- Log in the WebPOS. Generate a credit note, by either configuring the "Return overpayment as credit note" flag in a payment method, and then generating overpayment, or just generating a credit note from a returned order by using this development: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/73 [^] [^] [^]
- Create a ticket. Add products, Select to pay it with credit note. Input the document number of the credit note in the selector.
- Try to close the Dialog, realize that it gets closed.
(0131755)
hgbot   
2021-09-14 07:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/86 [^]
(0131836)
hgbot   
2021-09-15 18:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 1c11037ef54a70c437bc1ce5cb5130f67bbcf55a
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-09-15T16:42:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/1c11037ef54a70c437bc1ce5cb5130f67bbcf55a [^]

Fixes BUG-0047677: Close button in Gift Card Dialog Form does
not close the dialog

**Add options validForm with value false for close action as
expiration date for gift card is blank in case expiration days
is set as 0 in the organization.

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialogFormHandler.js
---
(0131837)
hgbot   
2021-09-15 18:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/86 [^]