Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047546 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] E. Translation | minor | always | 2021-08-13 09:44 | 2021-08-13 12:11 | |||
Reporter | caristu | View Status | public | |||||
Assigned To | caristu | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | PR21Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | Pre packaging ( pi ) | |||||||
Regression date | ||||||||
Regression introduced in release | pi | |||||||
Regression introduced by commit | https://gitlab.com/openbravo/product/openbravo/-/commit/0b38658966b3b6f7c03b9baca0945d491e796bcf [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047546: Install a translation module from the command line fails | |||||||
Description | After the changes introduced with 0047259 the installation of translation modules fails from the command line. This is because in that case WeldUtils is not properly initialized because we are outside of a servlet context. | |||||||
Steps To Reproduce | 1) Clone a translation module into the modules folder. Ex: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core.es_ES [^] 2) Run ant smartbuild -Dlocal=no The translation import process fails with the following error: [java] 2334 [main] ERROR org.openbravo.erpCommon.ad_forms.TranslationManager - importTrlFile - error parsing file: /home/openbravo/src/issues/openbravo/modules/org.openbravo.retail.posterminal.es_ES/referencedata/translation/es_ES//AD_ELEMENT_TRL_es_ES.xml [java] java.lang.NullPointerException: null [java] at org.openbravo.base.weld.WeldUtils.getStaticInstanceBeanManager(WeldUtils.java:54) ~[classes/:?] [java] at org.openbravo.base.weld.WeldUtils.getInstances(WeldUtils.java:129) ~[classes/:?] | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
||||||||
|
![]() |
|
(0131110) hgbot (developer) 2021-08-13 09:56 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/423 [^] |
(0131112) vmromanos (viewer) 2021-08-13 12:09 |
Tested and worked fine: - Install source - Translator Helper import properly updates POS labels after a refresh |
(0131113) hgbot (developer) 2021-08-13 12:11 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/423 [^] |
(0131114) hgbot (developer) 2021-08-13 12:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: cd23e2e3c994ee1d28f3566c3b1154f75189e338 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 2021-08-13T11:18:51+02:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/cd23e2e3c994ee1d28f3566c3b1154f75189e338 [^] fixes ISSUE-47546: Install translations from command line fails The TranslationManagerHook instances are retrieved with WeldUtils which can not be properly initialized outside of a servlet context, for example when installing translations directly from the command line. In that case a NPE was being thrown. Now we ensure that we are in a servlet context before trying to get the TranslationManagerHook instances with WeldUtils. --- M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java --- |
![]() |
|||
Date Modified | Username | Field | Change |
2021-08-13 09:44 | caristu | New Issue | |
2021-08-13 09:44 | caristu | Assigned To | => caristu |
2021-08-13 09:44 | caristu | OBNetwork customer | => OBPS |
2021-08-13 09:44 | caristu | Modules | => Core |
2021-08-13 09:44 | caristu | Triggers an Emergency Pack | => No |
2021-08-13 09:44 | caristu | Issue generated from | 0047259 |
2021-08-13 09:44 | caristu | Relationship added | caused by 0047259 |
2021-08-13 09:45 | caristu | Regression level | => Pre packaging ( pi ) |
2021-08-13 09:45 | caristu | Regression introduced in release | => pi |
2021-08-13 09:45 | caristu | Regression introduced by commit | => https://gitlab.com/openbravo/product/openbravo/-/commit/0b38658966b3b6f7c03b9baca0945d491e796bcf [^] |
2021-08-13 09:56 | hgbot | Merge Request Status | => open |
2021-08-13 09:56 | hgbot | Note Added: 0131110 | |
2021-08-13 11:18 | caristu | Summary | Install a translation module from the console fails => Install a translation module from the command line fails |
2021-08-13 11:18 | caristu | Description Updated | View Revisions |
2021-08-13 11:40 | caristu | OBNetwork customer | OBPS => No |
2021-08-13 12:09 | vmromanos | Note Added: 0131112 | |
2021-08-13 12:10 | hgbot | Merge Request Status | open => approved |
2021-08-13 12:11 | hgbot | Resolution | open => fixed |
2021-08-13 12:11 | hgbot | Status | new => closed |
2021-08-13 12:11 | hgbot | Note Added: 0131113 | |
2021-08-13 12:11 | hgbot | Fixed in Version | => PR21Q4 |
2021-08-13 12:11 | hgbot | Note Added: 0131114 |
Copyright © 2000 - 2009 MantisBT Group |