0004744: Callout SL_BankDebt_Amount causes loss of data in bank statement line tab

Notes
(0008803) psarobe (manager) 2008-09-01 11:01	The behavior of the "Statement amount" field is correct but we agree that the description field should not be overwrite. So the solution is only to change the description field behavior

(0008807) villind (developer) 2008-09-01 11:29	This behavior is really dangerous when there is integration with bank to get bank statement automatically. I don't really get the use case for changing the amounts, except maybe when the back statement line is created manually ant the payment is matched at the same time.

(0008819) svnbot (reporter) 2008-09-01 13:06	Repository: openbravo Revision: 6700 Author: vmromanos Date: 2008-09-01 13:06:15 +0200 (Mon, 01 Sep 2008) Fixed bug 0004744: The description field is not overwritten anymore. --- U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_BankDebt_Amount.java --- https://dev.openbravo.com/websvn/openbravo/?rev=6700&sc=1 [^]

(0008840) olli (reporter) 2008-09-02 09:05	I suggest the callout could work this way: if the "Statement amount" field is not filled (i.e. zero), the value is copied from the payment. If the "Statement amount" field is filled (i.e. non-zero), the value is not changed when the payment is associated with the bank statement line.

(0008841) vmromanos (manager) 2008-09-02 09:23	As villind wrote before, I think the behavior you are suggesting is dangerous. Nevertheless remember that if you want to change the Statement amount field manually, you can do it after filling the Payment field.

(0008844) villind (developer) 2008-09-02 09:44	If there needs to be this callout I think what ovihervu is suggesting is a acceptable solution: > If the "Statement amount" field is filled (i.e. non-zero), > the value is not changed when the payment is associated with > the bank statement line. I don't know how this is done in Spain or other countries, but no one in Finland is going to type in back statements manually. For us the payment selection is used only when we cannot match the back statement line with payment automatically. This may happen from 1% to 5% of cases.

(0008847) olli (reporter) 2008-09-02 11:29	In Finland the work sequence is like this: 1. Files which contain bank statement data are got from the bank and uploaded to Openbravo. 2. Openbravo generates bank statements and bank statement lines according to the data. 3. In addition, payments are automatically reconciled with the bank statement lines. 4. But sometimes the auto-reconciliation cannot be done, e.g. when the amounts don't match (customer has paid wrong amount). In that case the reconciliation has to be done manually. 5. If a user inadvertently associates a wrong payment (with a wrong amount) to a bank statement line, valid data is lost. That is the problem we are facing.

(0008848) svnbot (reporter) 2008-09-02 13:07	Repository: openbravo Revision: 6737 Author: vmromanos Date: 2008-09-02 13:07:24 +0200 (Tue, 02 Sep 2008) issue 0004744: The description field is now the description written by the user concatenated with the payment description from the database. --- U trunk/src/org/openbravo/erpCommon/ad_callouts/SL_BankDebt_Amount.java --- https://dev.openbravo.com/websvn/openbravo/?rev=6737&sc=1 [^]

Issue History
Date Modified	Username	Field	Change
2008-08-28 14:23	olli	New Issue
2008-08-28 14:23	olli	Assigned To	=> cromero
2008-08-28 14:23	olli	sf_bug_id	0 => 2080435
2008-09-01 10:58	psarobe	Assigned To	cromero => vmromanos
2008-09-01 10:58	psarobe	Priority	normal => low
2008-09-01 10:58	psarobe	Severity	major => minor
2008-09-01 11:01	psarobe	Status	new => scheduled
2008-09-01 11:01	psarobe	Note Added: 0008803
2008-09-01 11:01	psarobe	fix_in_branch	=> trunk
2008-09-01 11:23	villind	Issue Monitored: villind
2008-09-01 11:29	villind	Note Added: 0008807
2008-09-01 13:06	svnbot	Checkin
2008-09-01 13:06	svnbot	Note Added: 0008819
2008-09-01 13:06	svnbot	Status	scheduled => resolved
2008-09-01 13:06	svnbot	Resolution	open => fixed
2008-09-01 13:06	svnbot	svn_revision	=> 6700
2008-09-02 09:05	olli	Note Added: 0008840
2008-09-02 09:23	vmromanos	Note Added: 0008841
2008-09-02 09:44	villind	Note Added: 0008844
2008-09-02 11:29	olli	Note Added: 0008847
2008-09-02 13:07	svnbot	Checkin
2008-09-02 13:07	svnbot	Note Added: 0008848
2008-09-02 13:07	svnbot	svn_revision	6700 => 6737
2008-12-08 17:37	psarobe	Regression testing	=> No
2008-12-08 17:37	psarobe	Status	resolved => closed

Relationships [ Relation Graph ] [ Dependency Graph ]