0047398: Error while importing : taxes field is wrong

Description

After some investigation the problem is that the code in Web POS is failing and not calculating the taxes when the ticket is DELETED and synchronized to the backend (it happens randomly and we don’t know exactly why)

Due to this problem, the taxes property in the order are arriving as an array instead of JSON:
Taxes: [] <— wrong
Taxes: {} <— right

Steps To Reproduce

As it is random we cannot ensure the steps
It just happens on standard ticket deletion

Proposed Solution

WE made this as a quick patch, but this is not the source issue fix :

OB.UTIL.HookManager.registerHook(
    'OBPOS_PreSyncReceipt',
    (args, callbacks) => {
      const order = args.receipt;
      if (
        (order.get('obposIsDeleted') &&
          OB.UTIL.isNullOrUndefined(order.get('taxes'))) ||
        order.get('taxes') instanceof Array
      ) {
        order.set('taxes', {});
        order.get('lines').models.forEach(line => {
          if (OB.UTIL.isNullOrUndefined(order.get('net'))) {
            line.set('net', 0);
          }
        });
      }

      OB.UTIL.HookManager.callbackExecutor(args, callbacks);
    }
  );

Tags

No tags attached.

Attached Files

20Q3_TaxArray_ForceCashup.diff [^] (1,306 bytes) 2021-08-24 11:40 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js b/web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js
index e905649da..53b7369db 100644
--- a/web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js
+++ b/web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js
@@ -70,7 +70,13 @@ OB.OBPOSCloseCash.Model.CloseCash = OB.Model.TerminalWindowModel.extend({
     this.finishLoad();
   },
   loadModels: function(loadModelsCallback) {
-    loadModelsCallback();
+    if (OB && OB.Taxes && OB.Taxes.Pos && !OB.Taxes.Pos.ruleImpls) {
+      OB.Taxes.Pos.initCache(function() {
+        loadModelsCallback();
+      });
+    } else {
+      loadModelsCallback();
+    }
   },
   finishLoad: function() {
     let finish = true;
diff --git a/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
index 125e681a6..4805eeec1 100644
--- a/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
+++ b/web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
@@ -122,7 +122,7 @@
   const initializeTaxes = function(receipt) {
     receipt.set(
       {
-        taxes: []
+        taxes: {}
       },
       {
         silent: true

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0130502) egoitz (manager) 2021-07-15 11:38	Together with that problem, there are cases in which the net is set to null instead of 0. Both problems happen together.

(0131289) marvintm (manager) 2021-08-24 11:40	This issue should be resolved by the patch attached.

Issue History
Date Modified	Username	Field	Change
2021-07-15 11:12	sebastien_liron	New Issue
2021-07-15 11:12	sebastien_liron	Assigned To	=> Retail
2021-07-15 11:12	sebastien_liron	Resolution time	=> 1630274400
2021-07-15 11:12	sebastien_liron	Triggers an Emergency Pack	=> No
2021-07-15 11:38	egoitz	Note Added: 0130502
2021-07-15 11:38	egoitz	Issue Monitored: egoitz
2021-07-19 22:53	rqueralta	Assigned To	Retail => rqueralta
2021-07-19 22:53	rqueralta	Status	new => scheduled
2021-08-24 11:40	marvintm	File Added: 20Q3_TaxArray_ForceCashup.diff
2021-08-24 11:40	marvintm	Note Added: 0131289
2021-08-24 11:40	marvintm	Status	scheduled => resolved
2021-08-24 11:40	marvintm	Resolution	open => fixed
2021-08-24 11:40	marvintm	Assigned To	rqueralta => ranjith_qualiantech_com
2021-08-24 11:40	marvintm	Review Assigned To	=> marvintm
2021-08-24 11:40	marvintm	Status	resolved => closed