Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047215 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | always | 2021-06-23 09:22 | 2021-06-28 17:26 | |||
| Reporter | jmelin | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 64 bit | Database | PostgreSQL | Java version | 7.x | |||
| OS Version | Openbravo Appliance 14.04 | Database version | 9.3.x | Ant version | 1.9.x | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2021-03-16 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b8fde8a7bf3a7beece33da5cff38204b8f1f9493#a5ccd333ab96571c23fbd8439b70cb4cfdfaf04c_14_15 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047215: JIRA 2140 - Approval doesn't work in offline | |||||||
| Description | When the POS is offline, it is not possible to approve an user action, even if the user uses to approve already approve on the POS and/or log in to the POS | |||||||
| Steps To Reproduce | Case 1 1. In BO, set an user action to "Require approval" for a user (User 1 below) and "Can use and approve" for an other (User 2) 2. Connect to POS with User 1 3. Try to do the action with approval 4. Enter User 2 credential to approve 5. Disconnect network from OB Central 6. Try to do the action with approval 7. Enter User 2 credential to approve => action can't be approve Case 2 1. In BO, set an user action to "Require approval" for a user (User 1 below) and "Can use and approve" for an other (User 2) 2. Connect to POS with User 2 and log out 3. Connect to POS with User 1 4. Try to do the action with approval 5. Enter User 2 credential to approve 6. Disconnect network from OB Central 7. Try to do the action with approval 8. Enter User 2 credential to approve => action can't be approve | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0129738) alostale (manager) 2021-06-23 12:40 |
Regression caused by Offline<->Online Transitions Integration [1]. Changed in ApprovalChecker.js [2]: - const response = await OB.App.Request.mobileServiceRequest( + const response = await mobileServiceRequest( The original threw exception if server is not available whereas the latter tries to handle it. Approval code is expecting this exception to handle offline. --- [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/340 [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b8fde8a7bf3a7beece33da5cff38204b8f1f9493#a5ccd333ab96571c23fbd8439b70cb4cfdfaf04c_14_15 [^] |
|
(0129859) hgbot (developer) 2021-06-28 15:47 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/576 [^] |
|
(0129870) hgbot (developer) 2021-06-28 17:26 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 7f67383e70ad7f773e6e5dcc7416ceb3b1231bd8 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2021-06-28T15:25:16+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/7f67383e70ad7f773e6e5dcc7416ceb3b1231bd8 [^] Fixes ISSUE-47215: Approval doesn't work in offline Approval fails because of a change in mobileServiceRequest. It was previously throwing an exception, which was then used as reference to start offline approval. Now it doesn't throw an exception, so the result state is checked and if status is -1, offline approval is used instead. --- M web-jspack/org.openbravo.core2/src/core/security/ApprovalChecker.js M web-jspack/org.openbravo.core2/src/core/security/__test__/ApprovalChecker.test.js --- |
|
(0129871) hgbot (developer) 2021-06-28 17:26 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/576 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-06-23 09:22 | jmelin | New Issue | |
| 2021-06-23 09:22 | jmelin | Assigned To | => Retail |
| 2021-06-23 09:22 | jmelin | Triggers an Emergency Pack | => No |
| 2021-06-23 11:26 | dmiguelez | Status | new => scheduled |
| 2021-06-23 11:27 | dmiguelez | Resolution time | => 1625608800 |
| 2021-06-23 11:27 | dmiguelez | Assigned To | Retail => platform |
| 2021-06-23 11:27 | dmiguelez | Status | scheduled => acknowledged |
| 2021-06-23 12:40 | alostale | Note Added: 0129738 | |
| 2021-06-28 13:09 | cberner | Assigned To | platform => cberner |
| 2021-06-28 13:09 | cberner | Status | acknowledged => scheduled |
| 2021-06-28 13:09 | cberner | Relationship deleted | depends on 0047256 |
| 2021-06-28 15:47 | hgbot | Note Added: 0129859 | |
| 2021-06-28 16:22 | cberner | Regression level | => Pre packaging ( pi ) |
| 2021-06-28 16:22 | cberner | Regression date | => 2021-03-16 |
| 2021-06-28 16:22 | cberner | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b8fde8a7bf3a7beece33da5cff38204b8f1f9493#a5ccd333ab96571c23fbd8439b70cb4cfdfaf04c_14_15 [^] |
| 2021-06-28 17:26 | hgbot | Resolution | open => fixed |
| 2021-06-28 17:26 | hgbot | Status | scheduled => closed |
| 2021-06-28 17:26 | hgbot | Note Added: 0129870 | |
| 2021-06-28 17:26 | hgbot | Note Added: 0129871 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |