Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0047158
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coreminorhave not tried2021-06-16 12:082021-06-30 11:50
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047158: Clear text button should be clicked twice to clear form inputs

DescriptionClear text button should be clicked twice to clear form inputs
Steps To Reproduce1. Log in pos2
2. Open Customers window
3. Click on New Customer
4. Type any value in the name field
5. Press the "x" button of the field to clear it. ERROR: Note that it is not cleared
6- Press the "x" button again. Now the field is cleared.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0046975 closedplatform Field value in form is not correctly deleted when clearing with 'X' button 

-  Notes
(0129555)
hgbot (developer)
2021-06-16 12:11

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/564 [^]
(0130004)
hgbot (developer)
2021-06-30 11:50

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/564 [^]
(0130005)
hgbot (developer)
2021-06-30 11:50

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3f9df4d9fcdc1a1494c48be103db56bacf890003
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-06-30T09:46:58+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3f9df4d9fcdc1a1494c48be103db56bacf890003 [^]

fixes ISSUE-47158: clear text not working properly in form inputs

  Now the form inputs are cleared properly after pressing their clear
text button. To fix this, when the button is pressed we include a new
property named "type" in the onChange event to identify this flow. This
is necessary as in this case we want to force the processing of the
field value.

  Together with some improvements have been added:

  - Force the field cleared with the clear text button to acquire the
focus.
  - Now the "on change" feature of the form handler is fired even if
the field validation fails.
  - The debounced dispatch is immediately fired when the "on change"
execution finishes.
  - Centralize the logic of the clear input button used by
BaseFormInput, BaseFormDatePicker and BaseFormTimePicker components.

---
A web-jspack/org.openbravo.core2/src/components/BaseFormInput/ClearInputButton.jsx
A web-jspack/org.openbravo.core2/src/components/BaseFormInput/ClearInputButton.scss
A web-jspack/org.openbravo.core2/src/components/BaseFormInput/__test__/clearInput.js
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.scss
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/__test__/BaseFormInput.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/stories/BaseFormInput.stories.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/ConfigurableForm.test.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/TestForm.config.json
---

- Issue History
Date Modified Username Field Change
2021-06-16 12:08 caristu New Issue
2021-06-16 12:08 caristu Assigned To => caristu
2021-06-16 12:08 caristu Triggers an Emergency Pack => No
2021-06-16 12:11 hgbot Note Added: 0129555
2021-06-16 16:42 jarmendariz Relationship added related to 0047104
2021-06-16 16:43 jarmendariz Relationship added related to 0046975
2021-06-16 16:43 jarmendariz Relationship deleted related to 0047104
2021-06-16 18:38 dmiguelez Resolution time => 1626213600
2021-06-16 18:38 dmiguelez Status new => acknowledged
2021-06-30 11:50 hgbot Note Added: 0130004
2021-06-30 11:50 hgbot Resolution open => fixed
2021-06-30 11:50 hgbot Status acknowledged => closed
2021-06-30 11:50 hgbot Note Added: 0130005


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker