Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046915

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] Core

major

have not tried

2021-06-01 08:37

2021-07-15 13:41

Reporter

caristu

View Status

public

Assigned To

jarmendariz

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0046915: No UI feedback in case of having failed messages in the synchronization buffer queue

Description

If there is an error while processing a synchronization buffer message, the synchronization buffer handles it, avoiding the message removal from the queue until it is correctly synchronized.

In that case there is no UI feedback informing about this, the message queue may be growing with messages pending to be synchronized and users can't notice about this.

Steps To Reproduce

0) Apply the attached patch in mobile.core module which simulates an error while synchronizing the order with the backend when its finished. Run ant build to deploy the change.
1) Create and ticket, add a product and pay it.
2) The background synchronization of the ticket with the backend failed and no message was shown in the UI. You can also check with dev tools that the number of enqueued messages is increasing.

Proposed Solution

Add a listener to the synchronization buffer that shows a message in the UI when a backend sync message fails.

Tags

No tags attached.

syncFail.diff [^] (1,450 bytes) 2021-07-12 13:46 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js
index 3c01a1a6..00e25792 100644
--- a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js
+++ b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/BackendEndpoint.js
@@ -44,6 +44,9 @@
     }
 
     async doBackendRequest(message) {
+      if (message.modelName === 'OBPOS_Order') {
+        throw new Error('should not sync orders');
+      }
       const response = await OB.App.Request.mobileServiceRequest(
         message.service,
         { ...message.messageObj, messageId: message.id }
diff --git a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
index 01a82cbc..165fe639 100644
--- a/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
+++ b/web/org.openbravo.mobile.core/app/model/synchronization-buffer/SynchronizationBuffer.js
@@ -248,6 +248,8 @@
           }
         );
       } catch (error) {
+        const current = await OB.App.MessageModelController.findAll();
+        console.log(`Fialed sync. Current length ${current.length}`);
         this.notifyEventToListeners(
           endpoint.getName(),
           eventType.SYNC_PROCESS_FAILED,

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0046914		closed	prakashmurugesan88	Errors sending email must be caught
related to	feature request	0047244		acknowledged	Triage Platform Base	Pending to synchronize list should be updated in real-time
depends on	backport	0047008	TAP	closed	jarmendariz	No UI feedback in case of having failed messages in the synchronization buffer queue

Notes
(0130371) hgbot (developer) 2021-07-12 13:27	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/588 [^]

(0130511) hgbot (developer) 2021-07-15 13:41	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/588 [^]

(0130512) hgbot (developer) 2021-07-15 13:41	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: d91b6cd83a6caccaf660ca156ca7734a7220e7df Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 2021-07-15T11:41:00+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/d91b6cd83a6caccaf660ca156ca7734a7220e7df [^] Fixed ISSUE-46915: Adding a sync buffer listener to show an error message when a synchronization with backend fails --- M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.core2/src/authentication/loginInitActions.js ---

Issue History
Date Modified	Username	Field	Change
2021-06-01 08:37	caristu	New Issue
2021-06-01 08:37	caristu	Assigned To	=> platform
2021-06-01 08:37	caristu	File Added: printError.diff
2021-06-01 08:37	caristu	Triggers an Emergency Pack	=> No
2021-06-01 08:37	caristu	Issue generated from	0046914
2021-06-01 08:37	caristu	Relationship added	related to 0046914
2021-06-01 08:39	caristu	Resolution time	=> 1624312800
2021-06-07 15:07	guilleaer	Status	new => scheduled
2021-06-07 15:07	guilleaer	Status	scheduled => acknowledged
2021-06-14 21:59	jarmendariz	Assigned To	platform => jarmendariz
2021-06-24 15:48	jarmendariz	Relationship added	related to 0047244
2021-07-12 13:27	hgbot	Note Added: 0130371
2021-07-12 13:45	jarmendariz	File Deleted: printError.diff
2021-07-12 13:45	jarmendariz	Status	acknowledged => scheduled
2021-07-12 13:46	jarmendariz	File Added: syncFail.diff
2021-07-12 13:50	jarmendariz	Steps to Reproduce Updated	View Revisions
2021-07-12 13:50	jarmendariz	Proposed Solution updated
2021-07-14 09:45	dmiguelez	Resolution time	1624312800 => 1628028000
2021-07-15 13:41	hgbot	Note Added: 0130511
2021-07-15 13:41	hgbot	Resolution	open => fixed
2021-07-15 13:41	hgbot	Status	scheduled => closed
2021-07-15 13:41	hgbot	Note Added: 0130512

Copyright © 2000 - 2009 MantisBT Group