0046864: SafeBox - NonUniqueResultException happen when is finalize the count safe box

Description

In org.openbravo.retail.posterminal.ProcessCountSafeBox when is found the safebox missing the organization filter in the below query.

  OBCriteria<OBPOSSafeBox> safeBoxCriteria = OBDal.getInstance()
        .createCriteria(OBPOSSafeBox.class);
    safeBoxCriteria.add(
        Restrictions.eq(OBPOSSafeBox.PROPERTY_SEARCHKEY, jsonCountSafeBox.getString("safeBox")));
    OBPOSSafeBox safebox = (OBPOSSafeBox) safeBoxCriteria.uniqueResult();

Steps To Reproduce

1)Go in the erp
2)open the window safe box
3)configure two safe boxes with same searchkey and different organization
4)Login in the pos
5)Do the count safe box action and finalize it
6)Check the error in openbravo.log

Below the error
An error happened when processing a record:
org.hibernate.NonUniqueResultException: query did not return a unique result: 2

Proposed Solution

Add to the query the organization filter

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0128875) hgbot (developer) 2021-06-01 16:34	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/447 [^]

(0128926) hgbot (developer) 2021-06-02 09:46	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/447 [^]

(0128927) hgbot (developer) 2021-06-02 09:46	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 140ef8dcdbe463be95c36c84c2ca4399d613541c Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-06-02T07:46:37+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/140ef8dcdbe463be95c36c84c2ca4399d613541c [^] Fixed BUG-46864: Filtered by safe box organization --- M src/org/openbravo/retail/posterminal/ProcessCountSafeBox.java ---

Issue History
Date Modified	Username	Field	Change
2021-05-27 12:50	nicola_uva	New Issue
2021-05-27 12:50	nicola_uva	Assigned To	=> Retail
2021-05-27 12:50	nicola_uva	Resolution time	=> 1622412000
2021-05-27 12:50	nicola_uva	Regression introduced in release	=> pi
2021-05-27 12:50	nicola_uva	Triggers an Emergency Pack	=> No
2021-05-27 12:53	nicola_uva	Resolution time	1622412000 => 1622844000
2021-05-27 12:53	nicola_uva	Priority	normal => high
2021-05-27 12:53	nicola_uva	Steps to Reproduce Updated	View Revisions
2021-05-27 12:54	nicola_uva	Severity	minor => major
2021-05-28 18:22	rqueralta	Assigned To	Retail => rqueralta
2021-06-01 16:34	hgbot	Note Added: 0128875
2021-06-02 09:46	hgbot	Resolution	open => fixed
2021-06-02 09:46	hgbot	Status	new => closed
2021-06-02 09:46	hgbot	Note Added: 0128926
2021-06-02 09:46	hgbot	Fixed in Version	=> RR21Q3
2021-06-02 09:46	hgbot	Note Added: 0128927