Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046735

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Gift cards and gift vouchers

major

always

2021-05-19 16:31

2021-05-24 08:01

Reporter

guillermogil

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR21Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

Regression level

Production - Confirmed Stable

Regression date

2020-07-03

Regression introduced in release

RR20Q4

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3450a35bb1b147d078e3a6ae988695d2416ccd0d#04d7bcf0e0c675a50ab0b5cf9171e6cf4e48447f_127_135 [^]

Triggers an Emergency Pack

No

Summary

0046735: Buy GiftCard popup fails on identifier and cancellation

Description

When you try to sale a GC the popup raises, if you click cancel the GC gets added with the identifier you assigned.

If you add a new GC the same identifier is still shown.

Steps To Reproduce

Login on POS
Add a GC
click cancel

It gets added

Add a new one

The same id is there

See video attached

Proposed Solution

See diff attached

Tags

No tags attached.

2021-05-19 15-28-13.mkv [^] (1,618,207 bytes) 2021-05-19 16:31

fix46735.diff [^] (896 bytes) 2021-05-19 17:45 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js b/web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js
index 64968677a..7cc710f8c 100644
--- a/web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js
+++ b/web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js
@@ -35,6 +35,7 @@ enyo.kind({
     if (this.args.callback) {
       this.args.callback({ ...this.formData });
     }
+    this.formData = {};
     if (
       this.args &&
       this.args.requiredFiedls &&
@@ -86,7 +87,7 @@ enyo.kind({
   },
   loadValue: function(mProperty, component) {
     this.waterfall('onLoadValue', {
-      model: this.currentLine,
+      model: (this.args && this.args.forceLoad)? undefined : this.currentLine,
       modelProperty: mProperty,
       extraParams: this.args
     });

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0046740	RR21Q2	closed	ranjith_qualiantech_com	Buy GiftCard popup fails on identifier and cancellation
depends on	backport	0046741	RR21Q1.2	closed	ranjith_qualiantech_com	Buy GiftCard popup fails on identifier and cancellation
depends on	backport	0046742	RR20Q4.4	closed	ranjith_qualiantech_com	Buy GiftCard popup fails on identifier and cancellation

Notes
(0128440) hgbot (developer) 2021-05-20 11:52	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/426 [^]

(0128537) hgbot (developer) 2021-05-24 08:01	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/426 [^]

(0128538) hgbot (developer) 2021-05-24 08:01	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: b93923081d56824523e3956689a18f1d7e8e9fa4 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-05-24T06:00:51+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b93923081d56824523e3956689a18f1d7e8e9fa4 [^] Fixed ISSUE-46735: FormData should be cleared when closing the receipt line properties popup --- M web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js ---

Issue History
Date Modified	Username	Field	Change
2021-05-19 16:31	guillermogil	New Issue
2021-05-19 16:31	guillermogil	Assigned To	=> Retail
2021-05-19 16:31	guillermogil	File Added: 2021-05-19 15-28-13.mkv
2021-05-19 16:31	guillermogil	Resolution time	=> 1622239200
2021-05-19 16:31	guillermogil	Triggers an Emergency Pack	=> No
2021-05-19 17:45	marvintm	File Added: fix46735.diff
2021-05-19 17:46	guillermogil	Regression level	=> Production - Confirmed Stable
2021-05-19 17:46	guillermogil	Regression introduced in release	=> RR20Q4
2021-05-19 17:46	guillermogil	Proposed Solution updated
2021-05-19 17:51	marvintm	Status	new => scheduled
2021-05-19 17:54	marvintm	Regression date	=> 2020-07-03
2021-05-19 17:54	marvintm	Regression introduced by commit	=> https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3450a35bb1b147d078e3a6ae988695d2416ccd0d#04d7bcf0e0c675a50ab0b5cf9171e6cf4e48447f_127_135 [^]
2021-05-20 06:54	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2021-05-20 11:52	hgbot	Note Added: 0128440
2021-05-24 08:01	hgbot	Note Added: 0128537
2021-05-24 08:01	hgbot	Resolution	open => fixed
2021-05-24 08:01	hgbot	Status	scheduled => closed
2021-05-24 08:01	hgbot	Fixed in Version	=> RR21Q3
2021-05-24 08:01	hgbot	Note Added: 0128538

Copyright © 2000 - 2009 MantisBT Group