Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046658
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2021-05-13 12:562021-06-09 11:02
ReportercbernerView Statuspublic 
Assigned Toprakashmurugesan88 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelCoding ( Testing )
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046658: Some stories have their styles broken after BaseButton scss refactor

DescriptionSeveral stories, as per the screenshot provided, have their css styles broken and should be corrected to be equal as before or follow the correct styling.

The provided screenshots are only 3 examples, all stories with buttons should be checked, there are more that have incorrect styling.
Steps To ReproduceOpen storybook story -> https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/storybook/?path=/story/platform-propertybutton--simple-use [^]
Tagsscss
Attached Filespng file icon Broken-story1.png [^] (49,970 bytes) 2021-05-13 12:57


png file icon Broken-story2.png [^] (113,838 bytes) 2021-05-13 12:57


png file icon Broken-story3.png [^] (92,622 bytes) 2021-05-13 12:57

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046604 closedprakashmurugesan88 Style broken in action buttons for Grid stories 

-  Notes
(0129138)
prakashmurugesan88 (viewer)
2021-06-07 13:21

 Stories to be fixed,
https://docs.google.com/spreadsheets/d/10PYT8lvFze7VAy5RVLkLh6oNxGA-JcoO4GjO_pMiVlg/edit?usp=sharing [^]
(0129207)
guilleaer (viewer)
2021-06-08 17:35
edited on: 2021-06-08 17:36

 Updated res time because it is an internal minor issue
(0129219)
hgbot (developer)
2021-06-09 08:58

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/550 [^]
(0129220)
hgbot (developer)
2021-06-09 08:59

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/535 [^]
(0129221)
hgbot (developer)
2021-06-09 09:06

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/5 [^]
(0129222)
hgbot (developer)
2021-06-09 09:07

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/46 [^]
(0129224)
hgbot (developer)
2021-06-09 09:08

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/merge_requests/9 [^]
(0129226)
prakashmurugesan88 (viewer)
2021-06-09 09:21

 BaseButton has no styling
So no change required from BaseButton stories(Broken-story1.png)
(0129230)
hgbot (developer)
2021-06-09 11:01

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e1059022fa26baf0cf85668efd12566e02b6a348
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-09T10:48:42+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e1059022fa26baf0cf85668efd12566e02b6a348 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.core2/src/components/ConfigurableButton/stories/ConfigurableButton.stories.scss
A web-jspack/org.openbravo.core2/src/components/OrgVariables/stories/OrgVariables.stories.scss
M web-jspack/org.openbravo.core2/src/components/BaseMenu/stories/BaseMenu.stories.jsx
M web-jspack/org.openbravo.core2/src/components/BaseMenu/stories/MockBaseMenu.scss
M web-jspack/org.openbravo.core2/src/components/ConfigurableButton/stories/ConfigurableButton.stories.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/stories/Grid.stories.scss
M web-jspack/org.openbravo.core2/src/components/MoreButtonsMenu/stories/MoreButtonsMenu.stories.jsx
M web-jspack/org.openbravo.core2/src/components/MoreButtonsMenu/stories/MoreButtonsMenu.stories.scss
M web-jspack/org.openbravo.core2/src/components/OrgVariables/stories/OrgVariables.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
---
(0129231)
hgbot (developer)
2021-06-09 11:01

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/550 [^]
(0129232)
hgbot (developer)
2021-06-09 11:01

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 48402c174bdf1ff57c8bccc238d10f6d7fcc13c6
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-09T10:55:26+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/48402c174bdf1ff57c8bccc238d10f6d7fcc13c6 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/stories/TicketListRemoteGrid.stories.scss
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupDifference/stories/CashupDifference.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupDifference/stories/CashupDifferenceStory.scss
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CurrencyDisplay/stories/CurrencyDisplay.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CurrencyDisplay/stories/CurrencyDisplay.stories.scss
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/stories/TicketListRemoteGrid.stories.jsx
---
(0129233)
hgbot (developer)
2021-06-09 11:01

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/535 [^]
(0129234)
hgbot (developer)
2021-06-09 11:01

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey [^]
Changeset: a8bc3a87b13fd12cf0802fc3e3e63c464d36d469
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T16:21:03+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/commit/a8bc3a87b13fd12cf0802fc3e3e63c464d36d469 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurvey.stories.jsx
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurveyStories.scss
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurveyStoriesUtils.jsx
---
(0129235)
hgbot (developer)
2021-06-09 11:01

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/5 [^]
(0129236)
hgbot (developer)
2021-06-09 11:02

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 1d061bd55725183a2ed31109993bf1ae321a2301
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T20:57:55+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/1d061bd55725183a2ed31109993bf1ae321a2301 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLinePopovers.stories.scss
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLinePopovers.stories.jsx
---
(0129237)
hgbot (developer)
2021-06-09 11:02

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/46 [^]
(0129238)
hgbot (developer)
2021-06-09 11:02

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3 [^]
Changeset: 0df9e27394359de3a84eac0bd41df3b589c5f43e
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T16:18:39+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/commit/0df9e27394359de3a84eac0bd41df3b589c5f43e [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.retail.axisc3/src/components/PaymentIntegration/stories/Autotest.stories.scss
M web-jspack/org.openbravo.retail.axisc3/src/components/PaymentIntegration/stories/Autotest.stories.jsx
---
(0129239)
hgbot (developer)
2021-06-09 11:02

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/merge_requests/9 [^]

- Issue History
Date Modified Username Field Change
2021-05-13 12:56 cberner New Issue
2021-05-13 12:56 cberner Assigned To => Retail
2021-05-13 12:56 cberner OBNetwork customer => No
2021-05-13 12:56 cberner Resolution time => 1623276000
2021-05-13 12:56 cberner Triggers an Emergency Pack => No
2021-05-13 12:57 cberner File Added: Broken-story1.png
2021-05-13 12:57 cberner File Added: Broken-story2png
2021-05-13 12:57 cberner File Deleted: Broken-story2png
2021-05-13 12:57 cberner File Added: Broken-story2.png
2021-05-13 12:57 cberner File Added: Broken-story3.png
2021-05-13 12:58 cberner Tag Attached: scss
2021-05-13 19:25 guilleaer Resolution time 1623276000 => 1621461600
2021-05-13 19:25 guilleaer Regression level => Coding ( Testing )
2021-05-13 19:25 guilleaer Status new => acknowledged
2021-05-24 17:55 guilleaer Resolution time 1621461600 => 1622757600
2021-05-27 09:52 guilleaer Relationship added related to 0046604
2021-06-04 12:52 prakashmurugesan88 Assigned To Retail => prakashmurugesan88
2021-06-04 12:52 prakashmurugesan88 Status acknowledged => scheduled
2021-06-07 13:21 prakashmurugesan88 Note Added: 0129138
2021-06-08 17:35 guilleaer Resolution time 1622757600 => 1624485600
2021-06-08 17:35 guilleaer Note Added: 0129207
2021-06-08 17:36 guilleaer Note Edited: 0129207 View Revisions
2021-06-08 17:36 guilleaer Note Edited: 0129207 View Revisions
2021-06-09 08:58 hgbot Merge Request Status => open
2021-06-09 08:58 hgbot Note Added: 0129219
2021-06-09 08:59 hgbot Note Added: 0129220
2021-06-09 09:06 hgbot Note Added: 0129221
2021-06-09 09:07 hgbot Note Added: 0129222
2021-06-09 09:08 hgbot Note Added: 0129224
2021-06-09 09:21 prakashmurugesan88 Note Added: 0129226
2021-06-09 10:48 hgbot Merge Request Status open => approved
2021-06-09 11:01 hgbot Resolution open => fixed
2021-06-09 11:01 hgbot Status scheduled => closed
2021-06-09 11:01 hgbot Note Added: 0129230
2021-06-09 11:01 hgbot Note Added: 0129231
2021-06-09 11:01 hgbot Note Added: 0129232
2021-06-09 11:01 hgbot Note Added: 0129233
2021-06-09 11:01 hgbot Note Added: 0129234
2021-06-09 11:01 hgbot Note Added: 0129235
2021-06-09 11:02 hgbot Note Added: 0129236
2021-06-09 11:02 hgbot Note Added: 0129237
2021-06-09 11:02 hgbot Note Added: 0129238
2021-06-09 11:02 hgbot Note Added: 0129239

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker