Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046658POS2POSpublic2021-05-13 12:562021-06-09 11:02
Reportercberner 
Assigned Toprakashmurugesan88 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelCoding ( Testing )
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046658: Some stories have their styles broken after BaseButton scss refactor
DescriptionSeveral stories, as per the screenshot provided, have their css styles broken and should be corrected to be equal as before or follow the correct styling.

The provided screenshots are only 3 examples, all stories with buttons should be checked, there are more that have incorrect styling.
Steps To ReproduceOpen storybook story -> https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/storybook/?path=/story/platform-propertybutton--simple-use [^]
Proposed Solution
Additional Information
Tagsscss
Relationships
related to defect 0046604 closed prakashmurugesan88 Style broken in action buttons for Grid stories 
Attached Filespng Broken-story1.png (49,970) 2021-05-13 12:57
https://issues.openbravo.com/file_download.php?file_id=15729&type=bug
png

png Broken-story2.png (113,838) 2021-05-13 12:57
https://issues.openbravo.com/file_download.php?file_id=15731&type=bug
png

png Broken-story3.png (92,622) 2021-05-13 12:57
https://issues.openbravo.com/file_download.php?file_id=15732&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-13 12:56cbernerNew Issue
2021-05-13 12:56cbernerAssigned To => Retail
2021-05-13 12:56cbernerOBNetwork customer => No
2021-05-13 12:56cbernerResolution time => 1623276000
2021-05-13 12:56cbernerTriggers an Emergency Pack => No
2021-05-13 12:57cbernerFile Added: Broken-story1.png
2021-05-13 12:57cbernerFile Added: Broken-story2png
2021-05-13 12:57cbernerFile Deleted: Broken-story2png
2021-05-13 12:57cbernerFile Added: Broken-story2.png
2021-05-13 12:57cbernerFile Added: Broken-story3.png
2021-05-13 12:58cbernerTag Attached: scss
2021-05-13 19:25guilleaerResolution time1623276000 => 1621461600
2021-05-13 19:25guilleaerRegression level => Coding ( Testing )
2021-05-13 19:25guilleaerStatusnew => acknowledged
2021-05-24 17:55guilleaerResolution time1621461600 => 1622757600
2021-05-27 09:52guilleaerRelationship addedrelated to 0046604
2021-06-04 12:52prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-06-04 12:52prakashmurugesan88Statusacknowledged => scheduled
2021-06-07 13:21prakashmurugesan88Note Added: 0129138
2021-06-08 17:35guilleaerResolution time1622757600 => 1624485600
2021-06-08 17:35guilleaerNote Added: 0129207
2021-06-08 17:36guilleaerNote Edited: 0129207bug_revision_view_page.php?bugnote_id=0129207#r22703
2021-06-08 17:36guilleaerNote Edited: 0129207bug_revision_view_page.php?bugnote_id=0129207#r22704
2021-06-09 08:58hgbotMerge Request Status => open
2021-06-09 08:58hgbotNote Added: 0129219
2021-06-09 08:59hgbotNote Added: 0129220
2021-06-09 09:06hgbotNote Added: 0129221
2021-06-09 09:07hgbotNote Added: 0129222
2021-06-09 09:08hgbotNote Added: 0129224
2021-06-09 09:21prakashmurugesan88Note Added: 0129226
2021-06-09 10:48hgbotMerge Request Statusopen => approved
2021-06-09 11:01hgbotResolutionopen => fixed
2021-06-09 11:01hgbotStatusscheduled => closed
2021-06-09 11:01hgbotNote Added: 0129230
2021-06-09 11:01hgbotNote Added: 0129231
2021-06-09 11:01hgbotNote Added: 0129232
2021-06-09 11:01hgbotNote Added: 0129233
2021-06-09 11:01hgbotNote Added: 0129234
2021-06-09 11:01hgbotNote Added: 0129235
2021-06-09 11:02hgbotNote Added: 0129236
2021-06-09 11:02hgbotNote Added: 0129237
2021-06-09 11:02hgbotNote Added: 0129238
2021-06-09 11:02hgbotNote Added: 0129239

Notes
(0129138)
prakashmurugesan88   
2021-06-07 13:21   
Stories to be fixed,
https://docs.google.com/spreadsheets/d/10PYT8lvFze7VAy5RVLkLh6oNxGA-JcoO4GjO_pMiVlg/edit?usp=sharing [^]
(0129207)
guilleaer   
2021-06-08 17:35   
(edited on: 2021-06-08 17:36)
Updated res time because it is an internal minor issue
(0129219)
hgbot   
2021-06-09 08:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/550 [^]
(0129220)
hgbot   
2021-06-09 08:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/535 [^]
(0129221)
hgbot   
2021-06-09 09:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/5 [^]
(0129222)
hgbot   
2021-06-09 09:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/46 [^]
(0129224)
hgbot   
2021-06-09 09:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/merge_requests/9 [^]
(0129226)
prakashmurugesan88   
2021-06-09 09:21   
BaseButton has no styling
So no change required from BaseButton stories(Broken-story1.png)
(0129231)
hgbot   
2021-06-09 11:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/550 [^]
(0129230)
hgbot   
2021-06-09 11:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e1059022fa26baf0cf85668efd12566e02b6a348
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-09T10:48:42+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e1059022fa26baf0cf85668efd12566e02b6a348 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.core2/src/components/ConfigurableButton/stories/ConfigurableButton.stories.scss
A web-jspack/org.openbravo.core2/src/components/OrgVariables/stories/OrgVariables.stories.scss
M web-jspack/org.openbravo.core2/src/components/BaseMenu/stories/BaseMenu.stories.jsx
M web-jspack/org.openbravo.core2/src/components/BaseMenu/stories/MockBaseMenu.scss
M web-jspack/org.openbravo.core2/src/components/ConfigurableButton/stories/ConfigurableButton.stories.jsx
M web-jspack/org.openbravo.core2/src/components/Grid/stories/Grid.stories.scss
M web-jspack/org.openbravo.core2/src/components/MoreButtonsMenu/stories/MoreButtonsMenu.stories.jsx
M web-jspack/org.openbravo.core2/src/components/MoreButtonsMenu/stories/MoreButtonsMenu.stories.scss
M web-jspack/org.openbravo.core2/src/components/OrgVariables/stories/OrgVariables.stories.jsx
M web-jspack/org.openbravo.core2/src/components/StandardInputDataDialog/stories/StandardInputDataDialog.stories.jsx
---
(0129232)
hgbot   
2021-06-09 11:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 48402c174bdf1ff57c8bccc238d10f6d7fcc13c6
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-09T10:55:26+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/48402c174bdf1ff57c8bccc238d10f6d7fcc13c6 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/stories/TicketListRemoteGrid.stories.scss
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupDifference/stories/CashupDifference.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupDifference/stories/CashupDifferenceStory.scss
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CurrencyDisplay/stories/CurrencyDisplay.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountDisplay/CurrencyDisplay/stories/CurrencyDisplay.stories.scss
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/stories/TicketListRemoteGrid.stories.jsx
---
(0129233)
hgbot   
2021-06-09 11:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/535 [^]
(0129234)
hgbot   
2021-06-09 11:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey [^]
Changeset: a8bc3a87b13fd12cf0802fc3e3e63c464d36d469
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T16:21:03+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/commit/a8bc3a87b13fd12cf0802fc3e3e63c464d36d469 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurvey.stories.jsx
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurveyStories.scss
M web-jspack/org.openbravo.pos2.marketingsurvey/src/components/MarketingSurvey/stories/MarketingSurveyStoriesUtils.jsx
---
(0129235)
hgbot   
2021-06-09 11:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.marketingsurvey/-/merge_requests/5 [^]
(0129236)
hgbot   
2021-06-09 11:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 1d061bd55725183a2ed31109993bf1ae321a2301
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T20:57:55+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/1d061bd55725183a2ed31109993bf1ae321a2301 [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLinePopovers.stories.scss
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/stories/TicketMenuLinePopovers.stories.jsx
---
(0129237)
hgbot   
2021-06-09 11:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/46 [^]
(0129238)
hgbot   
2021-06-09 11:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3 [^]
Changeset: 0df9e27394359de3a84eac0bd41df3b589c5f43e
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-06-08T16:18:39+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/commit/0df9e27394359de3a84eac0bd41df3b589c5f43e [^]

Fixed BUG-46658: Fixes broken styles of button in stories

---
A web-jspack/org.openbravo.retail.axisc3/src/components/PaymentIntegration/stories/Autotest.stories.scss
M web-jspack/org.openbravo.retail.axisc3/src/components/PaymentIntegration/stories/Autotest.stories.jsx
---
(0129239)
hgbot   
2021-06-09 11:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.axisc3/-/merge_requests/9 [^]