0046524: JIRA 1834 - Credit note can be applied when already used

Description

It is possible to apply a credit note already used.

In this case, this is not the amount of the credit note that is applied but the rest to pay of the sales order.

Steps To Reproduce

For more informations, follow the guide gift cards module for POS2 User Guide
https://docs.google.com/document/d/1fl1MLX7UVexVNazL_B6sCju2a93bOBXkeR9ZvNI8ifY/edit# [^]

On livebuild:

In BO :

connect with Openbravo user and role “White valley group admin”

create payment provider for ‘Credit note’

create payment method ‘credit note’

create financial account ‘credit note’ and add payment method ‘credit note’

add payment method ‘credit note’ to the touchpoint type of the POS VBS-2 and link payment provider ‘credit note’

look for “voucher” payment method in the same touchpoint type, and check “Return overpayment on credit note”

add payment type ‘credit note’ to the POS VBS-2 link to payment method ‘credit note’

in “Organization”, set credit notes expiration to 30 days and check “Credit note used only once”

On POS:

Connect to VBS-2 using vallblanca user

Create an order and pay by voucher with an amount > to the rest to pay (ex: 20€ if have to pay 5€).

- check in BO that a gift card has been created and note the key of the gift card -

Create an order and pay using the previous credit note (and using payment if necessary) → the credit note must be as ‘used’

Create an order again, pay using the same credit note and apply (the credit note is shown as used)

=> it creates a payment of the rest to pay of type ‘credit note’

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0046515

closed

Sandrahuguet

JIRA 1834 - Credit note can be applied when already used

Notes
(0127882) lorenzofidalgo (developer) 2021-05-07 08:40	This issue is also reproducible following these steps: 1-Once Credit Notes are properly configured in backoffice, login POS2 as centralmountains. 2-Add 1x "Avalanche transceiver", pay 200€ to generate overpayment with Card and generate, this way, a Credit Note. 3-Now, add 1x "Hiking Boots" and pay with the just created Credit Note (there will no be enough money to complete de payment), add again the previous Credit Note and all the amount will be covered even when Credit Note < Total Amount. DEFECT: This way any amount can be paid with any Credit Note.

(0127950) guilleaer (manager) 2021-05-10 15:27	https://gitlab.com/obcustomers/AGAP/org.openbravo.retail.giftcards/-/merge_requests/1 [^]

(0127952) guilleaer (manager) 2021-05-10 15:30	Fixed by https://gitlab.com/obcustomers/AGAP/org.openbravo.retail.giftcards/-/commit/94e622f0376f9e41774ec93a474c633b0bb998ac [^]

Issue History
Date Modified	Username	Field	Change
2021-05-05 17:28	guilleaer	Type	defect => backport
2021-05-05 17:28	guilleaer	Target Version	=> TAP
2021-05-05 17:28	guilleaer	Status	scheduled => acknowledged
2021-05-05 17:28	guilleaer	Resolution time	=> 1621375200
2021-05-05 17:28	guilleaer	Steps to Reproduce Updated	View Revisions
2021-05-07 08:40	lorenzofidalgo	Note Added: 0127882
2021-05-10 15:27	Sandrahuguet	Assigned To	Retail => Sandrahuguet
2021-05-10 15:27	Sandrahuguet	Status	acknowledged => scheduled
2021-05-10 15:27	guilleaer	Note Added: 0127950
2021-05-10 15:27	Sandrahuguet	Note Added: 0127951
2021-05-10 15:29	guilleaer	Note Deleted: 0127951
2021-05-10 15:29	guilleaer	Status	scheduled => resolved
2021-05-10 15:29	guilleaer	Fixed in Version	=> TAP
2021-05-10 15:29	guilleaer	Resolution	open => fixed
2021-05-10 15:30	guilleaer	Review Assigned To	=> guilleaer
2021-05-10 15:30	guilleaer	Note Added: 0127952
2021-05-10 15:30	guilleaer	Status	resolved => closed