Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046471
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2021-05-03 17:592021-06-03 09:46
ReporterjavietxeView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046471: JIRA 1594: CRM Connector, focus directly in the field with error

DescriptionWhen creating or updating a business partner in the CRM connector, the mandatory fields and the validations are executed when the "Save and assign" button is pressed.

The fields with errors are marked in red showing the error message in each field.

The problem is that in big forms, the error can be not very easy to find, as you have to scroll up and down looking for the field in error.

The solution can be putting the focus in the first field with error when validating the fields.
Steps To ReproduceLog in into a POS with the CRM Connector configured (for example, agapes test).

Open the "New customer" form. Fulfill some fields, letting mandatory fields empty.

Click in save and assign button.

Check that even the field is marked in error, if the form is too big, it can be hard to find.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0046838TAP closedjarmendariz JIRA 1594: CRM Connector, focus directly in the field with error 
blocks defect 0046888 closedcaristu Focus is lost in form if on change function takes some time to be completed 

-  Notes
(0128718)
guilleaer (manager)
2021-05-27 14:28

Changed resolution time because due to technical reasons this fix is more cmplex than expected
(0128778)
hgbot (developer)
2021-05-29 20:18

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/524 [^]
(0128992)
hgbot (developer)
2021-06-03 09:33

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 303585aac2afdb7e2b2db81711e074b295a0b6c5
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-06-03T09:32:32+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/303585aac2afdb7e2b2db81711e074b295a0b6c5 [^]

Fixed ISSUE-46471: BaseForm now focus the first error field when form validation fails

---
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/BaseForm.test.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/ConfigurableForm.test.jsx
---
(0128993)
hgbot (developer)
2021-06-03 09:33

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/524 [^]
(0128994)
hgbot (developer)
2021-06-03 09:46

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0fad0a0150396bf3bc4d3f927f7bff9561d808ad
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-06-03T09:46:05+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0fad0a0150396bf3bc4d3f927f7bff9561d808ad [^]

Related to ISSUE-46471: Added check to avoid setting the reference to a null inputRef

---
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
---

- Issue History
Date Modified Username Field Change
2021-05-03 17:59 javietxe New Issue
2021-05-03 17:59 javietxe Assigned To => Retail
2021-05-03 17:59 javietxe Resolution time => 1622412000
2021-05-03 17:59 javietxe Triggers an Emergency Pack => No
2021-05-03 18:04 guilleaer Status new => acknowledged
2021-05-25 19:44 guilleaer Assigned To Retail => platform
2021-05-25 19:46 guilleaer Severity minor => major
2021-05-25 19:46 guilleaer Status acknowledged => scheduled
2021-05-25 19:46 guilleaer Status scheduled => acknowledged
2021-05-26 18:19 jarmendariz Assigned To platform => jarmendariz
2021-05-26 18:19 jarmendariz Status acknowledged => scheduled
2021-05-27 14:28 guilleaer Resolution time 1622412000 => 1623016800
2021-05-27 14:28 guilleaer Note Added: 0128718
2021-05-28 12:20 caristu Relationship added blocks 0046888
2021-05-29 20:18 hgbot Note Added: 0128778
2021-06-03 09:33 hgbot Resolution open => fixed
2021-06-03 09:33 hgbot Status scheduled => closed
2021-06-03 09:33 hgbot Note Added: 0128992
2021-06-03 09:33 hgbot Note Added: 0128993
2021-06-03 09:46 hgbot Note Added: 0128994


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker