Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046471POS2POSpublic2021-05-03 17:592021-06-03 09:46
Reporterjavietxe 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046471: JIRA 1594: CRM Connector, focus directly in the field with error
DescriptionWhen creating or updating a business partner in the CRM connector, the mandatory fields and the validations are executed when the "Save and assign" button is pressed.

The fields with errors are marked in red showing the error message in each field.

The problem is that in big forms, the error can be not very easy to find, as you have to scroll up and down looking for the field in error.

The solution can be putting the focus in the first field with error when validating the fields.
Steps To ReproduceLog in into a POS with the CRM Connector configured (for example, agapes test).

Open the "New customer" form. Fulfill some fields, letting mandatory fields empty.

Click in save and assign button.

Check that even the field is marked in error, if the form is too big, it can be hard to find.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046838TAP closed jarmendariz JIRA 1594: CRM Connector, focus directly in the field with error 
blocks defect 0046888 closed caristu Focus is lost in form if on change function takes some time to be completed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-03 17:59javietxeNew Issue
2021-05-03 17:59javietxeAssigned To => Retail
2021-05-03 17:59javietxeResolution time => 1622412000
2021-05-03 17:59javietxeTriggers an Emergency Pack => No
2021-05-03 18:04guilleaerStatusnew => acknowledged
2021-05-25 19:44guilleaerAssigned ToRetail => platform
2021-05-25 19:46guilleaerSeverityminor => major
2021-05-25 19:46guilleaerStatusacknowledged => scheduled
2021-05-25 19:46guilleaerStatusscheduled => acknowledged
2021-05-26 18:19jarmendarizAssigned Toplatform => jarmendariz
2021-05-26 18:19jarmendarizStatusacknowledged => scheduled
2021-05-27 14:28guilleaerResolution time1622412000 => 1623016800
2021-05-27 14:28guilleaerNote Added: 0128718
2021-05-28 12:20caristuRelationship addedblocks 0046888
2021-05-29 20:18hgbotNote Added: 0128778
2021-06-03 09:33hgbotResolutionopen => fixed
2021-06-03 09:33hgbotStatusscheduled => closed
2021-06-03 09:33hgbotNote Added: 0128992
2021-06-03 09:33hgbotNote Added: 0128993
2021-06-03 09:46hgbotNote Added: 0128994

Notes
(0128718)
guilleaer   
2021-05-27 14:28   
Changed resolution time because due to technical reasons this fix is more cmplex than expected
(0128778)
hgbot   
2021-05-29 20:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/524 [^]
(0128992)
hgbot   
2021-06-03 09:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 303585aac2afdb7e2b2db81711e074b295a0b6c5
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-06-03T09:32:32+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/303585aac2afdb7e2b2db81711e074b295a0b6c5 [^]

Fixed ISSUE-46471: BaseForm now focus the first error field when form validation fails

---
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/BaseForm.test.jsx
M web-jspack/org.openbravo.core2/src/components/Form/__test__/ConfigurableForm.test.jsx
---
(0128993)
hgbot   
2021-06-03 09:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/524 [^]
(0128994)
hgbot   
2021-06-03 09:46   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 0fad0a0150396bf3bc4d3f927f7bff9561d808ad
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-06-03T09:46:05+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/0fad0a0150396bf3bc4d3f927f7bff9561d808ad [^]

Related to ISSUE-46471: Added check to avoid setting the reference to a null inputRef

---
M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx
M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx
---