Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046345 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | minor | have not tried | 2021-04-24 17:31 | 2021-04-28 18:57 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | javierRodriguez | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | guilleaer | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046345: OnExit popup is shown in manual discount exit when technically there is no changes | |||||||
| Description | OnExit popup is shown in manual discount exit when technically there is no changes | |||||||
| Steps To Reproduce | OnExit popup is shown in manual discount exit when technically there is no changes steps: 1. Go to manual discount 2. Add a discount and apply it 3. Navigate to other window (like order) | |||||||
| Tags | AGPInternal, Takeaway | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0127539) hgbot (developer) 2021-04-26 17:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/418 [^] |
|
(0127575) hgbot (developer) 2021-04-27 14:35 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 85f659ed52d2fcf7e4a670ebe5627b6bd10c92b9 Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-04-27T14:13:15+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/85f659ed52d2fcf7e4a670ebe5627b6bd10c92b9 [^] FIX ISSUE 46345 FIX ISSUE 46326: Manage properly the popup to discard or apply changes in discount flow and include discount option in ticket header popover Additionally, there are also same fixes to improve how manual discount global information must be cleaned and recreated when manual discount flow is open again --- M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountBackButton/DiscountBackButton.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountOnExitDialog/DiscountOnExitDialog.js M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountList.config.json M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountOnExitDialog/OrderDiscountOnExitDialog.js M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountOnExitDialog/__test__/OrderDiscountOnExitDialog.test.js M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountBackButton/GenericDiscountBackButton.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/GenericDiscountOnExitDialog/GenericDiscountOnExitDialog.js M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/TicketPopover.config.json M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SwitchToDiscounts.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SelectManualDiscountsToApply.js --- |
|
(0127577) hgbot (developer) 2021-04-27 14:35 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/418 [^] |
|
(0127578) hgbot (developer) 2021-04-27 14:35 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 5ee10427b33828ac331c51749c84f85ad213e331 Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-04-27T14:13:15+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5ee10427b33828ac331c51749c84f85ad213e331 [^] FIX ISSUE 46345 FIX ISSUE 46326: Fix discount on exit condition --- M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountBackButton/OrderDiscountBackButton.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountOnExitDialog/OrderDiscountOnExitDialog.js --- |
|
(0127580) hgbot (developer) 2021-04-27 14:35 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0e85f4b46716790ecdfbe4b4c417711fec5ad2c5 Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-04-27T14:13:15+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0e85f4b46716790ecdfbe4b4c417711fec5ad2c5 [^] FIX ISSUE 46345 FIX ISSUE 46326: Check also the posflow to set the condition to change window --- M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountBackButton/OrderDiscountBackButton.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountOnExitDialog/OrderDiscountOnExitDialog.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-04-24 17:31 | guilleaer | New Issue | |
| 2021-04-24 17:31 | guilleaer | Assigned To | => javierRodriguez |
| 2021-04-24 17:31 | guilleaer | Resolution time | => 1620165600 |
| 2021-04-24 17:31 | guilleaer | Triggers an Emergency Pack | => No |
| 2021-04-24 17:31 | guilleaer | Tag Attached: Takeaway | |
| 2021-04-24 17:32 | guilleaer | Status | new => scheduled |
| 2021-04-24 17:33 | guilleaer | Tag Attached: AGPInternal | |
| 2021-04-26 17:07 | hgbot | Note Added: 0127539 | |
| 2021-04-27 11:11 | guilleaer | Relationship added | has duplicate 0046362 |
| 2021-04-27 14:35 | hgbot | Note Added: 0127575 | |
| 2021-04-27 14:35 | hgbot | Note Added: 0127577 | |
| 2021-04-27 14:35 | hgbot | Note Added: 0127578 | |
| 2021-04-27 14:35 | hgbot | Note Added: 0127580 | |
| 2021-04-27 15:33 | javierRodriguez | Status | scheduled => resolved |
| 2021-04-27 15:33 | javierRodriguez | Resolution | open => fixed |
| 2021-04-28 18:57 | guilleaer | Review Assigned To | => guilleaer |
| 2021-04-28 18:57 | guilleaer | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |