Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046272
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2021-04-15 13:052021-05-11 11:00
ReporterebecerraView Statuspublic 
Assigned Topablobessone 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046272: JIRA 1687: When load a ticket from ERP the promotions not show the "identifier"

DescriptionWhen load a ticket from ERP with promotions the label for promotions displayed ignore the value of the "identifier" (OrderLineOffer.obdiscIdentifier).

This happens for discounts by line and also for discount by total when being showed in the separated place.
Steps To ReproduceIn agapes test: https://agapes-test.cloud.openbravo.com/ [^]

Login in a terminal

search for the ticket 00370011/0000335

See that the total discount is named "Comarch Discounts by Total" instead of the value in te identifier.

New steps

In Standard environment
Create and order
Add a product (avalanche transceiver)
Click on order line
In the popover select discount
Apply a discount to line (disc_5_var_euro) and press apply
Press pay
Order is created

If you load the order using orders everything is fine

Go to pgadmin
Open table c_orderline_offer (last line created)
Add something in column "em_obdisc_identifier"


Close the order and reload it again
Now the name of discount shown sould be the text added in em_obdisc_identifier

TagsTakeaway
Attached Filesdiff file icon issue46272.diff [^] (923 bytes) 2021-04-20 09:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0046351TAP closedpablobessone JIRA 1687: When load a ticket from ERP the promotions not show the "identifier" 

-  Notes
(0127302)
marvintm (manager)
2021-04-16 07:45

The main idea here is to show the "identifier" JSON property (which corresponds to the "ObdiscIdentifier" property in the backend model) if it exists. Otherwise, the discounts should be shown as they are now.

This will help mainly when showing discounts from orders coming from backend.

It should apply both for inline discounts and receipt discounts shown in the lower side of the order component.
(0127390)
hgbot (developer)
2021-04-20 16:29

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/403 [^]
(0127413)
hgbot (developer)
2021-04-21 12:13

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/403 [^]
(0127414)
guilleaer (manager)
2021-04-21 12:14

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/403/diffs?commit_id=fa84875d2fad943f91fdfa74b717fd9368455980 [^]
(0127947)
guilleaer (manager)
2021-05-10 15:08

Reopened. When flag (organization window) "show order discounts in a separate section" is enabled identifer is not being used
(0127968)
hgbot (developer)
2021-05-10 19:50

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/447 [^]
(0127987)
hgbot (developer)
2021-05-11 11:00

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cb8e6e1a84075a975cc67e40cf9358486baf0bab
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-11T09:00:01+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cb8e6e1a84075a975cc67e40cf9358486baf0bab [^]

fixed ISSUE-0046272: modified condition to use discount identifier when show order discounts in a separate section flag is enabled

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscountLine/TicketSummaryDiscountLine.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummaryDiscounts/TicketSummaryDiscounts.jsx
---
(0127988)
hgbot (developer)
2021-05-11 11:00

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/447 [^]

- Issue History
Date Modified Username Field Change
2021-04-15 13:05 ebecerra New Issue
2021-04-15 13:05 ebecerra Assigned To => Retail
2021-04-15 13:05 ebecerra Triggers an Emergency Pack => No
2021-04-15 13:11 javietxe Description Updated View Revisions
2021-04-15 13:11 javietxe Steps to Reproduce Updated View Revisions
2021-04-15 14:42 javietxe Issue Monitored: javietxe
2021-04-15 14:51 javietxe Summary When load a ticket from ERP the promotions not show the "identifier" => JIRA 1687: When load a ticket from ERP the promotions not show the "identifier"
2021-04-15 19:36 pablobessone Assigned To Retail => pablobessone
2021-04-16 07:45 marvintm Note Added: 0127302
2021-04-20 09:56 guilleaer File Added: issue46272.diff
2021-04-20 10:05 guilleaer Steps to Reproduce Updated View Revisions
2021-04-20 10:26 guilleaer Status new => scheduled
2021-04-20 16:29 hgbot Note Added: 0127390
2021-04-21 12:13 hgbot Note Added: 0127413
2021-04-21 12:14 guilleaer Note Added: 0127414
2021-04-21 12:14 guilleaer Status scheduled => resolved
2021-04-21 12:14 guilleaer Resolution open => fixed
2021-04-21 12:14 guilleaer Review Assigned To => guilleaer
2021-04-21 12:14 guilleaer Status resolved => closed
2021-04-26 12:22 javietxe Tag Attached: Takeaway
2021-04-26 12:34 guilleaer Status closed => new
2021-04-26 12:34 guilleaer Resolution fixed => open
2021-04-26 12:34 guilleaer Status new => scheduled
2021-04-26 12:34 guilleaer Status scheduled => resolved
2021-04-26 12:34 guilleaer Resolution open => fixed
2021-04-26 12:34 guilleaer Status resolved => closed
2021-05-10 15:03 guilleaer Status closed => new
2021-05-10 15:03 guilleaer Resolution fixed => open
2021-05-10 15:03 guilleaer Status new => scheduled
2021-05-10 15:08 guilleaer Note Added: 0127947
2021-05-10 15:11 guilleaer Resolution time => 1620770400
2021-05-10 19:50 hgbot Note Added: 0127968
2021-05-11 11:00 hgbot Resolution open => fixed
2021-05-11 11:00 hgbot Status scheduled => closed
2021-05-11 11:00 hgbot Note Added: 0127987
2021-05-11 11:00 hgbot Note Added: 0127988


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker