Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046271

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Lottery Code - Italy

major

always

2021-04-15 10:18

2021-04-27 11:11

Reporter

ucarrion

View Status

public

Assigned To

rqueralta

Priority

urgent

Resolution

fixed

Fixed in Version

RR21Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0046271: The lottery code info is not printed if a RTServer payment id is not 1 or 2

Description

The lottery code is not printed if any of the payments added in the transaction has not rt server payment id 1 (cash) or 2 (electronic).

Steps To Reproduce

-Login webpos till
-Add a product
-Insert a lottery code in the popup
-Pay the transaction using cash (id 1) and gift card (id 3)
-Complete the payment and check the printed ticket. There's no lottery code informed

Proposed Solution

The lottery code must be saved and printed just if any of the payment methods used in the transaction has rt server payment id 1 (cash) or 2 (electronic).

Tags

No tags attached.

d64374f51c668d707b6868a692a38f5e51d9cba5.diff [^] (705 bytes) 2021-04-15 16:04 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.lotterycode/js/hookUtils/oblotc-getlotterycode.js b/web/org.openbravo.retail.lotterycode/js/hookUtils/oblotc-getlotterycode.js
index cc0cb2c1d1517f8e2de65b1843933986e46c9cdc..5923897eaa7c282c85d47bdf5dbfcf5fe25a2080 100644
--- a/web/org.openbravo.retail.lotterycode/js/hookUtils/oblotc-getlotterycode.js
+++ b/web/org.openbravo.retail.lotterycode/js/hookUtils/oblotc-getlotterycode.js
@@ -41,7 +41,7 @@
           .obrtserRtspaymentgroup;
       return rtserverPaymentMethod === '1' || rtserverPaymentMethod === '2';
     });
-    return currentPayments.length === validPayments.length;
+    return validPayments.length > 0;
   };
 
   OB.LOTCODE = OB.LOTCODE || {};

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0127429) hgbot (developer) 2021-04-21 19:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.lotterycode/-/merge_requests/6 [^]

(0127561) hgbot (developer) 2021-04-27 11:11	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.lotterycode/-/merge_requests/6 [^]

Issue History
Date Modified	Username	Field	Change
2021-04-15 10:18	ucarrion	New Issue
2021-04-15 10:18	ucarrion	Assigned To	=> Retail
2021-04-15 10:18	ucarrion	OBNetwork customer	=> No
2021-04-15 10:18	ucarrion	Resolution time	=> 1618524000
2021-04-15 10:18	ucarrion	Triggers an Emergency Pack	=> No
2021-04-15 16:04	jorgewederago	File Added: d64374f51c668d707b6868a692a38f5e51d9cba5.diff
2021-04-15 18:30	marvintm	Resolution time	1618524000 => 1619733600
2021-04-16 23:27	rqueralta	Assigned To	Retail => rqueralta
2021-04-16 23:27	rqueralta	Status	new => scheduled
2021-04-19 12:12	marvintm	OBNetwork customer	No => Gold
2021-04-21 19:48	hgbot	Merge Request Status	=> open
2021-04-21 19:48	hgbot	Note Added: 0127429
2021-04-27 11:11	hgbot	Merge Request Status	open => approved
2021-04-27 11:11	hgbot	Note Added: 0127561
2021-04-27 11:11	marvintm	Status	scheduled => resolved
2021-04-27 11:11	marvintm	Fixed in Version	=> RR21Q3
2021-04-27 11:11	marvintm	Resolution	open => fixed
2021-04-27 11:11	marvintm	Review Assigned To	=> marvintm
2021-04-27 11:11	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group