Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046130
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminoralways2021-03-24 10:512021-04-26 18:13
ReporterjmelinView Statuspublic 
Assigned Toprakashmurugesan88 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046130: JIRA 1457 - Autocompletion should be disabled by default

DescriptionThe autocompletion should be disabled by default for textbox input

Otherwise, when creating/updating a BP for exemple, every previous input are proposed or autofilled (see capture)
Steps To Reproduceopen live builds (https://livebuilds.openbravo.com/retail_pos2_pgsql [^])
Login in backoffice Openbravo/openbravo
Move to Role "The White Valley Group Admin"
Go to client window
Select "The White Valley Group" client
In tab below "client information" scroll down to reach "CRM conector" section
Mark "Enable CRM conector". A dropdown will appear, there "Sample CRM Integration - Proxy" should be selected
Logout
Go to new POS2 (https://livebuilds.openbravo.com/retail_pos2_pgsql/web/pos/?terminal=VBS-2 [^]) and login (demouser/openbravo)
In the main menu (left side) select the option Customers
Press button new customer
Fill the form and save

If you do that several times, you will see that fields suggest previous values and this is wrong.
Proposed Solutionhttps://gist.github.com/niksumeiko/360164708c3b326bd1c8 [^]
TagsTakeaway
Attached Filespng file icon 2021-03-24.png [^] (105,746 bytes) 2021-03-24 10:51


png file icon 46130.PNG [^] (11,311 bytes) 2021-04-21 17:46

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046358TAP closedprakashmurugesan88 JIRA 1457 - Autocompletion should be disabled by default 

-  Notes
(0126928)
guilleaer (manager)
2021-03-25 19:11

 https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/417 [^]
(0126929)
hgbot (developer)
2021-03-25 19:12

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 4a24437fff9300d16e7bd9ede5db74a13c78fbbd
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-03-25T18:09:55+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/4a24437fff9300d16e7bd9ede5db74a13c78fbbd [^]

Fixes ISSUE-46130: Disabled Autocompletion in BaseFormInput

---
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
---
(0127026)
jmelin (reporter)
2021-03-30 13:24

 The autocomplete="off" doesn't seems to work properly on chrome
Using autocomplete="chrome-off" seems to be a workaround
see https://stackoverflow.com/questions/15738259/disabling-chrome-autofill [^]

Step to reproduce
1. Register an adress in Chrome
  - open "chrome://settings/addresses" [^] in Chrome
  - check that autofill is enabled.
  - add an address if none available

2. Then execute the steps describe previously
(0127065)
hgbot (developer)
2021-03-31 09:24

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/432 [^]
(0127089)
hgbot (developer)
2021-04-05 19:18

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/432 [^]
(0127090)
hgbot (developer)
2021-04-05 19:18

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 69c8fe15423c98d6998f534697cb292f3a8a96d8
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-04-05T17:17:45+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/69c8fe15423c98d6998f534697cb292f3a8a96d8 [^]

Fixes BUG-46130: Hided autocomplete in chrome when an address is registered in Chrome Settings

---
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
---
(0127426)
jmelin (reporter)
2021-04-21 17:47

 The issue is still present.

On livebuild, with Chrome.
Connect to VBS-2.
Check Customer screen and look for customer name
Clear the search.
Double click on the name filter=> the previous search is displayed (see attached picture)
(0127526)
guilleaer (manager)
2021-04-25 17:27

 We will remove disable autocompletion for filters also
(0127540)
hgbot (developer)
2021-04-26 17:57

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: f7792b34d0b456cb949fc317ae89947c719cc6da
Author: Prakash M <prakash@qualiantech.com>
Date: 2021-04-26T21:18:06+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/f7792b34d0b456cb949fc317ae89947c719cc6da [^]

Fixes BUG-46130: Fixes autofill in customer filter
* This reverts commit 69c8fe15423c98d6998f534697cb292f3a8a96d8.
* Fill addresses should be disabled in chrome as it can override autofill

---
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
---
(0127541)
prakashmurugesan88 (developer)
2021-04-26 18:13

 Regarding note 0127026:

In a production environment, fill addresses should be disabled in chrome.
Because this can override autofill property.

- Issue History
Date Modified Username Field Change
2021-03-24 10:51 jmelin New Issue
2021-03-24 10:51 jmelin Assigned To => Retail
2021-03-24 10:51 jmelin File Added: 2021-03-24.png
2021-03-24 10:51 jmelin Triggers an Emergency Pack => No
2021-03-24 15:38 guilleaer Status new => scheduled
2021-03-24 15:38 guilleaer Assigned To Retail => guilleaer
2021-03-24 23:19 guilleaer Assigned To guilleaer => prakashmurugesan88
2021-03-24 23:30 guilleaer Steps to Reproduce Updated View Revisions
2021-03-24 23:30 guilleaer Proposed Solution updated
2021-03-25 10:34 jmelin Summary Autocompletion should be disabled by default => JIRA 1457 - Autocompletion should be disabled by default
2021-03-25 19:11 guilleaer Note Added: 0126928
2021-03-25 19:12 hgbot Resolution open => fixed
2021-03-25 19:12 hgbot Status scheduled => resolved
2021-03-25 19:12 hgbot Note Added: 0126929
2021-03-25 19:13 guilleaer Review Assigned To => guilleaer
2021-03-25 19:13 guilleaer Status resolved => closed
2021-03-30 13:24 jmelin Assigned To prakashmurugesan88 => Retail
2021-03-30 13:24 jmelin Note Added: 0127026
2021-03-30 13:24 jmelin Status closed => new
2021-03-30 13:24 jmelin Resolution fixed => open
2021-03-31 01:28 guilleaer Assigned To Retail => prakashmurugesan88
2021-03-31 07:28 prakashmurugesan88 Status new => scheduled
2021-03-31 09:24 hgbot Note Added: 0127065
2021-04-05 19:18 hgbot Note Added: 0127089
2021-04-05 19:18 hgbot Resolution open => fixed
2021-04-05 19:18 hgbot Status scheduled => closed
2021-04-05 19:18 hgbot Note Added: 0127090
2021-04-21 17:46 jmelin File Added: 46130.PNG
2021-04-21 17:47 jmelin Note Added: 0127426
2021-04-21 17:47 jmelin Status closed => new
2021-04-21 17:47 jmelin Resolution fixed => open
2021-04-22 23:05 guilleaer Tag Attached: Takeaway
2021-04-22 23:08 guilleaer Resolution time => 1617746400
2021-04-23 09:56 guilleaer Resolution time 1617746400 => 1618956000
2021-04-23 09:56 guilleaer Severity major => minor
2021-04-23 09:58 guilleaer Status new => scheduled
2021-04-25 17:27 guilleaer Note Added: 0127526
2021-04-26 17:36 guilleaer Status scheduled => resolved
2021-04-26 17:36 guilleaer Resolution open => fixed
2021-04-26 17:36 guilleaer Status resolved => closed
2021-04-26 17:36 guilleaer Status closed => new
2021-04-26 17:36 guilleaer Resolution fixed => open
2021-04-26 17:36 guilleaer Status new => scheduled
2021-04-26 17:57 hgbot Resolution open => fixed
2021-04-26 17:57 hgbot Status scheduled => closed
2021-04-26 17:57 hgbot Note Added: 0127540
2021-04-26 18:13 prakashmurugesan88 Note Added: 0127541

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker